[kixelated]

Summary

Fixes every remaining just check failure on a macOS Nix dev shell (quest quest/m0/macos-check.md, deleted here).

• check cpp: the doc-sample and bench compile-only steps in sh/cpp/check.sh used -fsyntax-only. The Nix cc-wrapper skips its link flags (NIX_LDFLAGS, -lintl on darwin) only when it sees -c/-S/-E/-M, so clang -Werror rejected them as unused. -c -fsyntax-only fails too (clang flags -c unused), so the steps now compile with -c -o /dev/null. Reproduced on Linux with nixpkgs clang and NIX_LDFLAGS=-lintl: fails before, passes after.
• check py: autosummary writes moq.media.catalog.rst (the function) and moq.media.Catalog.rst (the record), which collide on a case-insensitive filesystem. autosummary_filename_map gives the function's stub its own name; the rendered docs keep both pages.
• test rs: two lint expectations never fire on macOS, and build.warnings = deny fails the build on an unfulfilled one. moq-bench host's Args expected dead_code off Linux, but nothing is dead there, so the expectation is gone. moq-audio's test Stream expected clippy::large_enum_variant, which macOS's extra system-audio variant evens out, so it now applies off macOS only.
• test rs: moq-c's a_resume_onto_a_new_level_reserves_on_the_new_track probed its test track with the default encoder kind, VideoToolbox on macOS, then opened the software encoder, whose profile differs, so the first frame already moved to a new track. The shared track_under_test now probes with the software encoder the tests open.
• test gh: sh/js/audit.test.py compared the audit's logged $PWD against resolved paths, and macOS's /tmp is a symlink to /private/tmp. The fixture's root is now resolved up front.

Verified: quest gate nix develop --command just check --all passes on an aarch64-darwin host (kixtop) at b239a866f, after just clean, with the dev shell's bun first on PATH. just check origin/main passes on Linux. The Platform workflow's macOS job runs none of these suites in the Nix shell, so it cannot verify this.

Not a repository problem, so not changed here: a shell rc that puts an older global bun (1.2.23 cannot read bun.lock's lockfile version) ahead of the dev shell fails every JS module, and installing with a newer bun than the dev shell's (1.4.4 against 1.4.2) duplicated typedoc under doc/.vitepress/api and failed moq-doc's typecheck.

Public API: none. Wire: none.

Caused by

• moq-dev/moq#4079 - added the -fsyntax-only -Werror doc-sample compile that the Nix wrapper feeds link flags

• moq-dev/moq#5745 - same pattern for the bench compile

• moq-dev/moq#8014 - expected dead_code on the host sampler's Args off Linux, which macOS does not report

• moq-dev/moq#7706 - expected clippy::large_enum_variant on the test capture enum on every platform

• moq-dev/moq#7110 - added the resume test assuming the default probe matches the software encoder it opens

• moq-dev/moq#5975 - compared the audit's unresolved temp paths against resolved ones

The docs collision has no single culprit: it appeared once moq.media exported both catalog and Catalog.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, low effort
Implementer: Claude Code, claude-opus-5-5, high effort

(Written by Claude Opus 5.5 with high)

Review

Rewritten by quest review after each round.

• Reviewer: Codex, gpt-6.1-sol, medium effort
• Session: 01a1ced4-f273-7920-a371-2cf9235be9ec, round 1
• Head: b239a86
• Base: origin/main at 2e0418f
• Score: 9/10, No actionable defects were found; the changes are narrowly scoped and consistent with surrounding code, though builds and tests were not run as instructed.
• Findings: none

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: f2c66e45-243a-49d4-ab0f-8af404667b7a

Commits

Reviewing files that changed from the base of the PR and between 01f50c1 and b239a86.

Files selected for processing: 7

• py/moq-rs/docs/conf.py
• quest/m0/macos-check.md
• rs/moq-audio/src/capture.rs
• rs/moq-bench/src/host.rs
• rs/moq-c/src/video.rs
• sh/cpp/check.sh
• sh/js/audit.test.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[pullfrog]

This run was cancelled before it finished.

  ^{｜ View workflow run ｜ via Pullfrog}