Skip to content

ci: add the release target to the pinned Rust toolchain - #8509

Merged
kixelated merged 1 commit into
mainfrom
ci/armv7-pinned-toolchain-target
Nov 12, 2026
Merged

kixelated merged 1 commit into
mainfrom
ci/armv7-pinned-toolchain-target

Conversation

@kixelated

@kixelated kixelated commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

moq-cli / release / Build (armv7-unknown-linux-gnueabihf) has failed every nightly since armv7 shipped in #8250 (job): E0463 can't find crate for core. dtolnay/rust-toolchain installs the armv7 std into the image's stable (1.99.1), but rust-toolchain.toml pins 1.98.1, which is what cargo actually runs, and that toolchain never gets the target. The native x86_64 and aarch64 builds pass only because the host std ships with every toolchain.

Approach

Replace the action in the Linux build job with rustup target add "$TARGET" run from the checkout, the same pattern android.yml uses: rustup resolves the pinned toolchain from rust-toolchain.toml and adds the target to it.

Impact

  • No public API or wire change. Restores the armv7 moq tarball and .deb in nightly and releases.

Alternatives

  • Listing armv7 under targets in rust-toolchain.toml: every developer and CI job would download its std.
  • toolchain: 1.98.1 on the action: duplicates the pin in another place to keep in sync.

Follow-ups

None. Other nightly failures triaged alongside this: Gate cost needs a host with a PMU (hosted ubuntu-24.04 VMs report No supported events found; the job has never passed), and the apt Temporary failure resolving errors were a roughly two hour Azure DNS outage for the Ubuntu archive hosts (apt on the same ubuntu-26.04 image worked at 12:50 UTC the same day and every prior night).

Models

  • Size: S
  • Implementer: Claude Code, claude-opus-5-5, low effort (iterate, S)

Review

Rewritten by quest review after each round.

  • Head: edeb4ba

  • Base: origin/main at a560df6

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d0b6-59ea-7ae0-9204-9050f0e05e68, round 1

  • Score: 9/10, The fix is narrowly scoped and consistent with the subsequent build, with no actionable regressions found by source review; no builds or tests were run.

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T17:12:02.605111Z edeb4ba Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: edeb4bab35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated
kixelated marked this pull request as ready for review November 12, 2026 17:03
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Linux build job replaces the stable toolchain and target installation step from dtolnay/rust-toolchain with rustup target add. It passes the matrix target through the TARGET environment variable. Rustup uses the toolchain pinned by the checkout’s rust-toolchain.toml.

Merge Risk: Minimal · up to edeb4

The change makes the Linux release build install the ARM target on the toolchain the repository pins, which should restore the nightly ARM artifacts. No merge-blocking risk was identified. The PR reports that no builds were run, so the next nightly run will confirm the fix.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: add the release target to the pinned Rust toolchain" matches the main change. The workflow now runs rustup target add "$TARGET" from the checkout, so rustup adds the armv7 target to t…
Description check Passed The description explains the armv7 build failure (E0463 can't find crate for core), the cause (the action installs the target into the image's stable toolchain, while rust-toolchain.toml pins a differ…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: add the release target to the pinned Rust toolchain" matches the main change. The workflow now runs rustup target add "$TARGET" from the checkout, so rustup adds the armv7 target to the toolchain pinned in rust-toolchain.toml. The title is specific and concise, and it names the actual fix.

Full details: Description check

Explanation

The description explains the armv7 build failure (E0463 can't find crate for core), the cause (the action installs the target into the image's stable toolchain, while rust-toolchain.toml pins a different version), and the fix (rustup target add from the checkout). It also covers alternatives and impact. It relates directly to the changeset in .github/workflows/release-binary.yml.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d901c027-48ab-41fa-9e4c-aeb62c43b93e
Commits

Reviewing files that changed from the base of the PR and between a4bc922 and edeb4ba.

Files selected for processing: 1

  • .github/workflows/release-binary.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Linux builds add the target to the pinned toolchain — the build job in .github/workflows/release-binary.yml drops dtolnay/rust-toolchain and runs rustup target add "$TARGET" from the checkout, so rustup resolves the rust-toolchain.toml pin instead of the image's stable.
  • Diagnosis checks out against the failing run — job 130595636479 logs rustup default stable leaving 1.98.1 in use via the override, then missing active toolchain 1.98.1-… has been auto-installed, then E0463 for armv7-unknown-linux-gnueabihf; the new step's ordering fixes exactly that.
  • The pattern is already proven in this repo — android.yml runs the same step against the same 1.98.1 pin, and its logs show rustup target add auto-installing the pinned toolchain before downloading the target's rust-std. rs/moq-ffi/build.sh:135 uses it too, so the FFI cross builds were never on the broken path.
  • Native targets are unaffected — the x86_64 and aarch64 matrix entries already ship their rust-std with the toolchain, so their rustup target add is a no-op, and the Windows/macOS jobs keep their current setup.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit abb7f89 Nov 12, 2026
9 checks passed
@kixelated
kixelated deleted the ci/armv7-pinned-toolchain-target branch November 12, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant