Repository navigation
ci: add the release target to the pinned Rust toolchain - #8509
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
No actionable comments were generated in the recent review. WalkthroughThe Linux build job replaces the stable toolchain and target installation step from Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Linux builds add the target to the pinned toolchain — the
buildjob in.github/workflows/release-binary.ymldropsdtolnay/rust-toolchainand runsrustup target add "$TARGET"from the checkout, so rustup resolves therust-toolchain.tomlpin instead of the image'sstable. - Diagnosis checks out against the failing run — job
130595636479logsrustup default stableleaving 1.98.1 in use via the override, thenmissing active toolchain 1.98.1-… has been auto-installed, thenE0463forarmv7-unknown-linux-gnueabihf; the new step's ordering fixes exactly that. - The pattern is already proven in this repo —
android.ymlruns the same step against the same 1.98.1 pin, and its logs showrustup target addauto-installing the pinned toolchain before downloading the target'srust-std.rs/moq-ffi/build.sh:135uses it too, so the FFI cross builds were never on the broken path. - Native targets are unaffected — the x86_64 and aarch64 matrix entries already ship their
rust-stdwith the toolchain, so theirrustup target addis a no-op, and the Windows/macOS jobs keep their current setup.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Problem
moq-cli / release / Build (armv7-unknown-linux-gnueabihf)has failed every nightly since armv7 shipped in #8250 (job):E0463 can't find crate for core.dtolnay/rust-toolchaininstalls the armv7 std into the image'sstable(1.99.1), butrust-toolchain.tomlpins 1.98.1, which is what cargo actually runs, and that toolchain never gets the target. The native x86_64 and aarch64 builds pass only because the host std ships with every toolchain.Approach
Replace the action in the Linux build job with
rustup target add "$TARGET"run from the checkout, the same patternandroid.ymluses: rustup resolves the pinned toolchain fromrust-toolchain.tomland adds the target to it.Impact
moqtarball and .deb in nightly and releases.Alternatives
targetsinrust-toolchain.toml: every developer and CI job would download its std.toolchain: 1.98.1on the action: duplicates the pin in another place to keep in sync.Follow-ups
None. Other nightly failures triaged alongside this: Gate cost needs a host with a PMU (hosted ubuntu-24.04 VMs report
No supported events found; the job has never passed), and the aptTemporary failure resolvingerrors were a roughly two hour Azure DNS outage for the Ubuntu archive hosts (apt on the same ubuntu-26.04 image worked at 12:50 UTC the same day and every prior night).Models
Review
Rewritten by
quest reviewafter each round.Head: edeb4ba
Base: origin/main at a560df6
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d0b6-59ea-7ae0-9204-9050f0e05e68, round 1Score: 9/10,
The fix is narrowly scoped and consistent with the subsequent build, with no actionable regressions found by source review; no builds or tests were run.Findings: none