chore: bump quest to ecf40e27 by kixelated · Pull Request #8463 · moq-dev/moq

kixelated · 2026-11-10T20:03:02Z

Bumps the quest flake input from 6a18b8a8 to ecf40e27 (compare), so this repository's dev shell gets the newer quest gate:

moq-dev/quest#604: quest gate --host is removed. A waiting --host reservation in a pinned older quest blocked about 30 gated commands on the shared desktop while its load sat at 4 on 24 CPUs.
moq-dev/quest#602: waiting commands start first come, first served.
moq-dev/quest#607: running commands count at their measured CPU peak, so a lull between a build's phases no longer admits another whole-host command.

The flake input's URL no longer carries a revision, so flake.lock alone pins it, as quest's automatic pin bumps do.

quest init refreshes the skill stubs and agent pointer, and quest check --fix applies the newer tree rules (an epic no longer lists its own quests under ## Required). quest check passes.

Review

Skipped: a pin bump changes no repository code; CI is the gate.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

coderabbitai · 2026-11-10T20:03:11Z

No actionable comments were generated in the recent review.

Walkthrough

The change removes or reduces “Required” lists across quest milestone and task README files. The m0 test-flakes README adds two required child tasks. The quest-review skill changes its model-selection wording. The quest flake input changes from a fixed commit to the repository’s default branch.

Merge Risk: Minimal · up to 27f64

The Quest update remains pinned, and roadmap dependencies remain represented. No merge-blocking issue was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly summarizes the primary change: bumping the quest dependency to the specified revision.
Description check		The description explains the quest dependency bump and the updated `quest gate` behavior, so it is related to the changeset.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Simplify code

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Source mode: Auto

Repository: Unavailable

Branch: Unavailable

File: No configuration file from this repository applied

Commit: Unavailable

Layers: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: `bf3733d0-0099-4002-8be5-11a6d4fb08c0`

Commits

Reviewing files that changed from the base of the PR and between `cf0da51` and `27f6411`.

Files ignored due to path filters: 1

`flake.lock` is excluded by `!**/*.lock`

Files selected for processing: 44

`.claude/skills/quest-review/SKILL.md`

`flake.nix`

`quest/README.md`

`quest/m0/README.md`

`quest/m0/ci/README.md`

`quest/m0/nightly/README.md`

`quest/m0/test-flakes-2/README.md`

`quest/m1/README.md`

`quest/m1/audio-jitter-target/README.md`

`quest/m1/explicit-state/README.md`

`quest/m1/stream-credit/README.md`

`quest/m2/README.md`

`quest/m2/cluster-routing/README.md`

`quest/m2/cluster-routing/routes/README.md`

`quest/m2/probe/README.md`

`quest/m2/subscribe-ranges/README.md`

`quest/m2/time-addressing/README.md`

`quest/m2/unbounded-groups/README.md`

`quest/m3/README.md`

`quest/m3/c/README.md`

`quest/m3/cache-routing/README.md`

`quest/m3/intra-refresh/README.md`

`quest/m3/layers/README.md`

`quest/m3/mesh/README.md`

`quest/m3/obs-moq-video/README.md`

`quest/m3/obs-studio/README.md`

`quest/m3/one-port/README.md`

`quest/m3/qos/README.md`

`quest/m3/quic-realtime/README.md`

`quest/m3/release/README.md`

`quest/m3/stats/README.md`

`quest/m3/stream/README.md`

`quest/m3/vendor-sync/README.md`

`quest/m3/video-quality/README.md`

`quest/m3/webrtc/README.md`

`quest/m3/wire-stats/README.md`

`quest/m4/README.md`

`quest/m4/kio-channel-contention/README.md`

`quest/m4/p2p/README.md`

`quest/m4/perf/README.md`

`quest/m4/stream-transports/README.md`

`quest/m5/README.md`

`quest/m5/e2ee/README.md`

`quest/m5/net-wrap/README.md`

Files with no reviewable changes: 42

quest/m3/mesh/README.md

quest/m3/layers/README.md

quest/m2/cluster-routing/routes/README.md

quest/m3/README.md

quest/m3/stream/README.md

quest/m4/kio-channel-contention/README.md

quest/m3/c/README.md

quest/m3/video-quality/README.md

quest/m3/obs-studio/README.md

quest/m3/stats/README.md

quest/m5/e2ee/README.md

quest/m5/net-wrap/README.md

quest/m3/one-port/README.md

quest/m0/test-flakes-2/README.md

quest/m3/wire-stats/README.md

quest/m1/explicit-state/README.md

quest/m3/qos/README.md

quest/m5/README.md

quest/m3/quic-realtime/README.md

quest/m2/probe/README.md

quest/m2/cluster-routing/README.md

quest/m3/obs-moq-video/README.md

quest/m2/time-addressing/README.md

quest/m0/README.md

quest/m3/release/README.md

quest/m0/ci/README.md

quest/m2/subscribe-ranges/README.md

quest/m4/p2p/README.md

quest/m1/stream-credit/README.md

quest/m1/audio-jitter-target/README.md

quest/m3/intra-refresh/README.md

quest/m4/README.md

quest/m3/webrtc/README.md

quest/m0/nightly/README.md

quest/m3/cache-routing/README.md

quest/m4/perf/README.md

quest/m2/unbounded-groups/README.md

quest/README.md

quest/m4/stream-transports/README.md

quest/m1/README.md

quest/m3/vendor-sync/README.md

quest/m2/README.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

kixelated

Automated review by review (OpenAI)

Reviewed the complete patch at fb28657 and the pinned Quest README/flake configuration. No actionable code findings.

Direction: the URL becomes updateable while flake.lock retains the exact revision. The deleted Required entries all name children of their own epic, matching the pinned Quest's implicit-child rules; cross-directory prerequisites remain intact. Do not restore these redundant indexes.

GitHub currently reports merge conflicts, so this head is not merge-ready. Verification limits: GitHub-only static review of the integration and migration, not a full audit of upstream Quest changes. No Nix evaluation, hash verification, build, or gate runtime tests executed.

pullfrog

ℹ️ Minor suggestions only — no code changes here; one prose follow-up and one stale comment.

Reviewed changes

Quest pin bump — flake.lock moves quest from 6a18b8a8 to ecf40e27 (and its quest-pinned input), and the upstream compare does contain the commits the description names: b6b7197e (#604, drops --host), 133ab156 (#602, first come first served), ecf40e27 (#607, CPU-peak accounting), plus f3a90694 (#554, quest check rejects epics listing their children).
Floating input URL — flake.nix drops the rev from the quest input so flake.lock alone pins it, leaving the comment above it describing an upgrade step that no longer exists.
Tree clean-up — 42 epic and milestone READMEs lose their ## Required sections (~630 lines of duplicated child titles), exactly what quest check --fix produces under the new rule. No quest is deleted or moved, and every surviving ## Required lists only non-children (m2 keeps drop-set and stream-credit from m1, m3/c keeps ffi-exporter, and so on).
Skill stub — .claude/skills/quest-review/SKILL.md picks up the refreshed description from #567; no stale copies of the old wording remain in the repo.

ℹ️ Thirteen m3 audits still point at the `## Required` section this PR deletes

Each recurring audit quest says its successor is added "at the end of m3's Required" (quest/m3/audit-lints.md:14 and twelve siblings). quest/m3/README.md now ends at its Plan, so following that instruction either appends a section that no longer exists or recreates one that the new quest check rule rejects as an epic listing its own children. Same root cause, lower stakes: quest/m2/recut-held.md:10-11 justifies its plan with "a child must stay listed by its own epic", which is the rule #554 removes — its conclusion still holds, but for the reason that a claimed child's branch is its path, not because of the listing.

Technical details

# Stale references to epic `## Required` sections

## Affected sites
- `quest/m3/audit-lints.md:14`, `audit-simplify.md:13`, `audit-test-coverage.md:11`,
  `audit-interop.md:16`, `audit-size.md:11`, `audit-docs.md:11`,
  `audit-test-cost.md:13`, `audit-compile-time.md:12`, `audit-quests.md:11`,
  `audit-ci.md:14`, `audit-perf.md:14`, `audit-deps.md:14`,
  `audit-dead-code.md:11` — "adds the next one with the same file name at the
  end of m3's `Required`".
- `quest/m2/recut-held.md:10-11` — "a child must stay listed by its own epic,
  so each epic waited for its claimed children".
- Lower stakes, same cause: `quest/m5/lite07-mesh.md:9`, `ada-gpu.md:10`,
  `webkit-319818.md:10`, `zero-copy-peer.md:9`, `video-hardware-access.md:12`
  say to delete "every `Required` entry that links it", and m5 has none now.

## Required outcome
- No quest tells a future run to edit a section that no longer exists or that
  `quest check` rejects.
- The audits still express "the successor becomes the newest quest in m3",
  which is now implicit from its path.

## Suggested approach (optional)
- Reword the audit line to say the successor joins m3 as its newest child
  (or "at the end of m3"), dropping the section reference.
- Reword `recut-held.md` to give the branch-is-the-path reason for waiting on
  claimed children.

</details>

<!--
Pullfrog review metadata. These findings were written against fb28657;
if commits have landed on quest-bump since, treat every specific bug, file, or
line callout as POTENTIALLY STALE and re-diff before acting on it.

- Mode: Review (initial)
- Files reviewed: 45
- Commits reviewed: 1
- Base: main (8c26d5b)
- Head: quest-bump (fb28657)
- Reviewed commits:
  - fb28657 — chore: bump quest to ecf40e27
- Prior pullfrog review: none
-->


<!-- PULLFROG_DIVIDER_DO_NOT_REMOVE_PLZ -->
<sup><a href="https://pullfrog.com"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pullfrog.com/logos/frog-white-full-18px.png"><img src="https://pullfrog.com/logos/frog-green-full-18px.png" width="9px" height="9px" style="vertical-align: middle; " alt="Pullfrog"></picture></a>&nbsp;&nbsp;｜ [Fix all ➔](https://pullfrog.com/trigger/moq-dev/moq/8463?action=fix&review_id=5848550305) ｜ [Fix 👍s ➔](https://pullfrog.com/trigger/moq-dev/moq/8463?action=fix-approved&review_id=5848550305) ｜ [View workflow run](https://github.com/moq-dev/moq/actions/runs/42891389227/job/130093148519) ｜ Using `deepseek-v4.1-flash-1017` (free via [Pullfrog for OSS](https://pullfrog.com/for-oss)) ｜ [𝕏](https://x.com/pullfrogai)</sup>

Brings in moq-dev/quest#604 (quest gate --host removed), #602 (gated commands start first come, first served), and #607 (running commands count at their measured CPU peak). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

pullfrog

ℹ️ No new issues in the delta; one carried-forward note below.

Reviewed changes

Comment reword — flake.nix:33 now points at nix flake update quest instead of a rev bump that no longer exists, retiring the earlier inline comment (thread resolved).
Rebase pickup — the quest/m3/README.md line for capture-list.md is deleted by this PR and now carries main's newer "placed on their displays" wording (cf0da51d, #8454), so it changes nothing in the final tree.

ℹ️ Thirteen m3 audits still point at the `## Required` section this PR deletes

This is the one item from the prior review the new commits do not touch: each recurring m3 audit still tells its successor to be added "at the end of m3's Required", a section this PR removes and the new quest check rule rejects. It is a prose follow-up in quest files outside this diff, so it is restated here rather than reopened inline; everything else from the prior review is addressed.

Technical details

# Stale references to epic `## Required` sections

## Affected sites
- `quest/m3/audit-lints.md:14`, `audit-simplify.md:13`, `audit-test-coverage.md:11`,
  `audit-interop.md:16`, `audit-size.md:11`, `audit-docs.md:11`,
  `audit-test-cost.md:13`, `audit-compile-time.md:12`, `audit-quests.md:11`,
  `audit-ci.md:14`, `audit-perf.md:14`, `audit-deps.md:14`,
  `audit-dead-code.md:11` — "adds the next one with the same file name at the
  end of m3's `Required`".
- `quest/m2/recut-held.md:15` — "a child must stay listed by its own epic",
  the rule #554 removes.

## Required outcome
- No quest tells a future run to edit a section that no longer exists or that
  `quest check` rejects.
- The audits still express "the successor becomes the newest quest in m3",
  which is now implicit from its path.

^{｜ Fix it ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏}

moq-bot · 2026-11-10T21:12:06Z

quest land watch: the merge queue removed this pull request at 27f6411 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

moq-bot · 2026-11-10T21:13:53Z

Codex land fixer: fixer crashed (exit 1); run /quest-iterate. Recommendation: run /quest-iterate before picking it again.

quest land check: [Errno 32] Broken pipe

(written by Codex)

kixelated · 2026-11-10T23:21:36Z

Superseded by #8464, which bumps quest further (to 2572be9c), adds the quest-run stub, and applies the new epic-list rule. Closing on the maintainer's pick.

(Written by Opus 5.5 with medium)

kixelated commented Nov 10, 2026

View reviewed changes

pullfrog Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread flake.nix Resolved

kixelated mentioned this pull request Nov 10, 2026

quest: drop the tested-base merge quest, planned on a wrong premise moq-dev/quest#611

Merged

kixelated added the quest:active label Nov 10, 2026

chore: bump quest to ecf40e27

3d16c8d

Brings in moq-dev/quest#604 (quest gate --host removed), #602 (gated commands start first come, first served), and #607 (running commands count at their measured CPU peak). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated force-pushed the quest-bump branch from fb28657 to 3d16c8d Compare November 10, 2026 20:07

chore: flake comment names nix flake update

27f6411

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated removed the quest:active label Nov 10, 2026

kixelated added this pull request to the merge queue Nov 10, 2026

pullfrog Bot reviewed Nov 10, 2026

View reviewed changes

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 10, 2026

kixelated closed this Nov 10, 2026

Navigation Menu

Repository navigation

chore: bump quest to ecf40e27 - #8463

chore: bump quest to ecf40e27#8463
kixelated wants to merge 2 commits into
mainfrom
quest-bump

kixelated commented Nov 10, 2026

Uh oh!

coderabbitai Bot commented Nov 10, 2026 •

edited

Loading

Uh oh!

kixelated left a comment

Uh oh!

pullfrog Bot left a comment

Uh oh!

Uh oh!

pullfrog Bot left a comment

Uh oh!

moq-bot Bot commented Nov 10, 2026

Uh oh!

moq-bot Bot commented Nov 10, 2026

Uh oh!

kixelated commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kixelated commented Nov 10, 2026

Review

Uh oh!

coderabbitai Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

kixelated left a comment

Choose a reason for hiding this comment

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

ℹ️ Thirteen m3 audits still point at the ## Required section this PR deletes

Uh oh!

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

ℹ️ Thirteen m3 audits still point at the ## Required section this PR deletes

Uh oh!

moq-bot Bot commented Nov 10, 2026

Uh oh!

moq-bot Bot commented Nov 10, 2026

Uh oh!

kixelated commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Nov 10, 2026 •

edited

Loading

ℹ️ Thirteen m3 audits still point at the `## Required` section this PR deletes

ℹ️ Thirteen m3 audits still point at the `## Required` section this PR deletes