Repository navigation
fix(gst): backport sandbox-safe Homebrew formula test to release - #8109
Conversation
Backports the moq-gst.rb.tmpl test from #5841: gst-inspect-1.0 hangs inside Homebrew's test sandbox on a headless Mac, failing every moq-gst tag since 0.4.20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Sandbox-safe Homebrew test:
.github/homebrew/Formula/moq-gst.rb.tmplreplaces thegst-inspect-1.0 moqcall intest dowith an existence check and alibgstreamer-1.0linkage assertion, matchingmain's copy from #5841 byte for byte.
I confirmed the failure this fixes: in the 0.4.23 tag run (job 128111899383) brew test reaches gst-inspect-1.0 moq, logs the CoreServices/XPC errors, then fails with Timeout::Error: execution expired after five minutes. I also confirmed the new test has already run green on macOS: dry run 39000627149 from #5841 used this exact formula content and finished without invoking gst-inspect-1.0. dynamically_linked_libraries reads the Mach-O or ELF headers in-process, so the test stays sandbox-safe.
(Written by DeepSeek V4.1 Flash 1017)
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 2c9e719 against release base 3ea7619. No actionable findings.
The formula is byte-identical to the current main template. The replacement checks the installed plugin and its GStreamer dynamic dependency without starting gst-inspect inside Homebrew's sandbox. I also checked the release-branch workflow and smoke script: the tarball is still loaded against system GStreamer outside that sandbox, with moqsink/moqsrc checked before the formula test.
Verification limits: GitHub-only static review; no Homebrew/macOS execution or release-tag reproduction. The exact-head Release gate succeeded, while Check was still in progress. The next moq-gst tag remains the end-to-end release proof tracked by #8105.
(Written by review (OpenAI))
0.4.21 through 0.4.23 published to crates.io, but their GitHub releases never did: the macOS Homebrew formula test hung inside Homebrew's sandbox. moq-dev#8109 backported the sandbox-safe test. This patch release has no code changes. It gives release-plz a version to publish and tag, which re-runs moq-gst.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Backports
.github/homebrew/Formula/moq-gst.rb.tmpl's test from moq-dev/moq#5841 torelease. Onreleasethe test still runsgst-inspect-1.0. That hangs inside Homebrew's test sandbox on a headless Mac, so everymoq-gst-v*tag since 0.4.20 timed out inBuild tarball (aarch64-apple-darwin)and skippedRelease. The new test checks that the plugin exists and linkslibgstreamer-1.0. The workflow's existing smoke-test step still loads the plugin outside the sandbox.Quest: moq-dev/moq#8105 (
quest/m0/ci/gst-release-macos.md).After merge, the maintainer cuts the next moq-gst tag to prove the fix. That step is tracked in the quest PR.
Review
Skipped: the change is
main'smoq-gst.rb.tmplcopied verbatim (git checkout origin/main --), and it was already reviewed and merged in moq-dev/moq#5841.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)