Repository navigation
chore(moq-e2ee): release v0.0.23 - #7990
moq-bot[bot] wants to merge 1 commit into
Conversation
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: 5331e10.
No actionable correctness findings in this three-file release diff. rs/moq-e2ee/Cargo.toml:8 and Cargo.lock:4335 consistently advance moq-e2ee from 0.0.22 to 0.0.23, and the changelog adds the matching release section. There are no source, public API, or wire-format changes in this PR.
Direction: the narrow release-metadata approach is appropriate; retain the normal CI and release validation before landing.
Limits: GitHub-only static review of the diff, manifest/workspace context, changelog, and existing discussion. No builds, tests, or publish dry run executed. Scope, Test, and Check were queued when inspected. Rechecked that the PR remains open and non-draft at this head, with no prior review submission.
There was a problem hiding this comment.
Caution
Merging this publishes moq-e2ee 0.0.23 with the full old implementation, after 0.0.22 on crates.io was already published as the final no-code release pointing users at moq-crypto. A published crate version can only be yanked, never replaced, so please confirm intent before landing.
Reviewed changes
- Version bump:
rs/moq-e2ee/Cargo.toml:8andCargo.lockmovemoq-e2eefrom 0.0.22 to 0.0.23. - Changelog: adds a 0.0.23 section containing eleven identical
- releaseentries. - No source, test, or benchmark files change, so the release carries nothing new beyond version metadata.
🚨 Publishing 0.0.23 undoes the 0.0.22 retirement
moq-e2ee is already retired on crates.io: 0.0.22 is a 1.4 KB tarball whose src/lib.rs is a single include_str!("../README.md"), described as "Renamed to moq-crypto", and whose README says "this final release contains no code". main keeps that same stub at rs/moq-e2ee and holds the real code in rs/moq-crypto (rename #7702). Merging triggers release-rs.yml, which runs release-plz release from release, where rs/moq-e2ee is still the full 14-file implementation with no publish = false, and nothing on release depends on it. That would ship the old crate again as a newer version than the tombstone, which cannot be undone.
Technical details
# Retire moq-e2ee on `release` instead of publishing 0.0.23
## Affected sites
- `rs/moq-e2ee/Cargo.toml:8` - the 0.0.23 bump that `release-plz release` would publish from `release`.
- `rs/moq-e2ee/CHANGELOG.md:12-24` - eleven `- release` entries. release-plz re-lists every `chore: release` commit since the `moq-e2ee-v0.0.21` tag because the 0.0.22 publish was never tagged.
- `.release-plz.toml` - no package exclusion, so `moq-e2ee` stays in the release set on `release`.
## Evidence
- `git diff moq-e2ee-v0.0.21 HEAD -- rs/moq-e2ee` touches only `CHANGELOG.md` and the `version` line: no source, test, or bench changes since 0.0.21.
- crates.io `moq-e2ee` 0.0.22 (published 2026-11-05T22:31Z) unpacks to one `src/lib.rs` line, the "Renamed to moq-crypto..." description, and `.cargo_vcs_info.json` sha1 `70789be5c...` with `dirty: true`.
- `origin/main` has the stub at `rs/moq-e2ee` (version 0.0.11) and the real implementation at `rs/moq-crypto`, with `MIGRATE.md` describing the merge (#7702).
- `release` has the full `rs/moq-e2ee/src`, keeps it as a workspace member, sets no `publish = false`, and no other release-branch crate depends on it.
## Required outcome
- Merging must not publish a non-retirement `moq-e2ee` 0.0.23.
- `release` should stop proposing `moq-e2ee` releases: backport the tombstone (README, one-line `src/lib.rs`, description, no dependencies) or exclude the package from release-plz, for example `[[package]] name = "moq-e2ee" publish = false` in `.release-plz.toml`.
## Open questions for the human
- Is 0.0.22 the intended cutoff? If `release` is meant to keep shipping `moq-e2ee`, the tombstone publish needs explaining and this release needs a real change to justify a new version.(Written by DeepSeek V4.1 Flash)
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

🤖 New release
moq-e2ee: 0.0.22 -> 0.0.23 (✓ API compatible changes)Changelog
This PR was generated with release-plz.