Repository navigation
feat(c)!: expose pre-encoded simulcast rate control #7947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b4b96c9
chore(quest): claim quest/m1/c/api-gaps.md
kixelated 69360a4
feat(c)!: expose audio enablement and normalize epoch errors
kixelated 38969e5
chore(quest): preserve C API validation blockers
kixelated c5b37c8
chore(quest): claim quest/m1/c/api-gaps.md
kixelated a411d74
chore(c): merge current claim and supersede the older API attempt
kixelated 9bfd74a
feat(c)!: expose pre-encoded simulcast rate control
kixelated 8d90d3c
fix(c): keep public rate-control exports before tests
kixelated 645ef13
docs(c): format simulcast migration notes
kixelated b86d6ec
docs(c): clarify audio enablement refusal
kixelated 0259171
fix(c): bind rate controls to a reservation and cover probing transit…
kixelated 6a70a11
Merge origin/main; moq_rate_control_update reports change via target.…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Exercise rate-control records and handle ownership across the generated C ABI. | ||
| #include <moq.h> | ||
| #include <assert.h> | ||
|
|
||
| int main(void) { | ||
| moq_video_init video = {0}; | ||
| assert(video.lower == 0); | ||
| moq_rate_policy policy = {.max_bps = 4000000, .lower_bps = 2000000, .has_lower = true}; | ||
| // A control refuses an invalid reservation at setup. | ||
| assert(moq_rate_control_create(0, policy) < 0); | ||
| moq_rate_target target = {0}; | ||
| assert(moq_rate_control_target(0, &target) < 0); | ||
| assert(moq_rate_control_update(0, &target) < 0); | ||
| assert(moq_rate_control_close(0) < 0); | ||
| return 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.