Skip to content

quest: finish the release fanout-threads bench (backport #7698) - #7695

Merged
kixelated merged 5 commits into
mainfrom
quest/m1/release-fanout-bench
Nov 3, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m1/release-fanout-bench

Conversation

@kixelated

@kixelated kixelated commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m1/release-fanout-bench.md. Its release backport, moq-dev/moq#7698, has merged (acf91a00b9, on origin/release). It ports session_fanout_threads from moq-dev/moq#7493 into release's single-file session bench.

Summary

  • Before starting, I checked that the quest was still needed. moq-dev/moq#7586 backported the other cases, but origin/release (338cb9b3e8) had no session_fanout_threads.
  • Deletes quest/m1/release-fanout-bench.md and its link in the m1 README, using quest rm. No other link to it remains in the tree.
  • The Release performance epic said release "carries it once that PR lands". It now says the backport merged in moq-dev/moq#7698.
  • Merged origin/main (9f6a327ef4) to clear the conflict in quest/m1/README.md. The quest merge driver resolved the link list.
  • quest check --base origin/main and sh/markdown.sh check pass.

Choices made without asking

These are recorded on moq-dev/moq#7698:

  • The round clock is reduced to Wall and Process. release has no SESSION_CPU thread-CPU mode, so main's Thread variant would be dead code there.
  • fanout_threads drops main's Backend type parameter, since release has only the model relay. Its case IDs are unchanged, because Model::PREFIX is "".

Automated findings

  • Pullfrog and the OpenAI review found no bugs on 3961b0f975. Both noted that this PR shouldn't land before moq-dev/moq#7698. That PR has merged, so the ordering condition is met.
  • CodeRabbit was rate-limited and didn't review.

Review

  • Codex (gpt-6.1-sol, medium effort), via quest review --base origin/main, round 1 on head 823d57b9afb92930e9eaefd52268f832b15b3ca7: 0 findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title release carries the fanout-threads bench quest: finish the release fanout-threads bench (backport #7698) Nov 3, 2026
@kixelated
kixelated marked this pull request as ready for review November 3, 2026 07:44
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47c05b4d-a151-4ae7-908b-374c978354a0
Commits

Reviewing files that changed from the base of the PR and between 9f6a327 and 823d57b.

Files selected for processing: 3
  • quest/m1/README.md
  • quest/m1/release-fanout-bench.md
  • quest/m1/release-perf/README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This PR closes the m1 release-fanout-bench quest, whose deliverable is the bench-only backport of session_fanout_threads to release in moq-dev/moq#7698.

  • Deleted quest file — quest/m1/release-fanout-bench.md removed, matching the established completion convention.
  • Index link removed — the quest bullet is dropped from quest/m1/README.md.
  • Decision sentence updated — quest/m1/release-perf/README.md now names #7698 instead of the vague "once that PR lands".

I verified the clearing condition: fetched release head 338cb9b3e8 has no session_fanout_threads in rs/moq-net/benches/session.rs, main does, and #7698 is the open backport to release. A repo-wide grep for release-fanout-bench finds no dangling references, and session_fanout_threads survives only in the edited release-perf sentence. #7586 (the other bench cases) is already merged into release.

One sequencing note, already stated on the PR: #7698 is still unmerged, so this tracking should not land before it, otherwise the quest disappears while release still lacks the bench.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 3961b0f

The quest cleanup is appropriate once #7698 lands; as Pullfrog also noted, it should not merge first. No additional actionable bugs found in this static review. I did not run tests or verify a completed release gate.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 823d57b

The condition from my previous review is now met: #7698 has merged into release, and release contains session_fanout_threads. The updated release-performance note accurately records that backport. I found no new actionable issue in the quest cleanup or merge integration.

Verification: Static GitHub-only inspection of the changed quest files, #7698's merge state, and the release benchmark source. I did not run the benchmark or release gate.

(Written by review, OpenAI)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the delta since the prior Pullfrog review (3961b0f). The only authored change is a doc citation update; the remaining diff is merge noise from origin/main.

  • Cited the merged backport — quest/m1/release-perf/README.md now says the bench-only backport merged in #7698 instead of "once that PR lands".
  • Merged origin/main — the quest index and merge-conflict resolution net out against main, leaving only the intended quest-bullet removal.

I verified the claim the new sentence makes: #7698 is merged into release at acf91a00b9 (touching rs/moq-net/benches/session.rs), and release:rs/moq-net/benches/session.rs now contains fn fanout_threads. The prior review's sequencing condition is therefore met, and no release-fanout-bench references remain.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 2b2f16e Nov 3, 2026
9 of 10 checks passed
@kixelated
kixelated deleted the quest/m1/release-fanout-bench branch November 3, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant