Skip to content

chore(quest): finish paired benchmark baseline wait - #7592

Merged
moq-bot[bot] merged 3 commits into
mainfrom
quest/m0/nightly/bench-baseline-build
Nov 2, 2026
Merged

moq-bot[bot] merged 3 commits into
mainfrom
quest/m0/nightly/bench-baseline-build

Conversation

@kixelated

@kixelated kixelated commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The wait quest tracks the paired baseline's Cargo alias merge failure. The latest scheduled Nightly (2026-11-01) has passed that build blocker.

Approach

Delete the completed quest and its parent link. No code change is needed: moq-dev/moq#7445 already isolates baseline worktrees from the current checkout's Cargo configuration.

Verified the run's logs:

  • Rust bench targets: baseline build finished at 14:15:28 UTC, then ran Criterion criterion-base targets. It was later cancelled while measuring memory/streams=1/size=1048576, before final comparison.
  • Shared targets: both builds and paired comparison completed, reporting six confirmed regressions and no targets missing comparison.
  • Supplemental targets: reached comparison, but reported 15 targets not compared after the baseline lacked moq-sign. This is not evidence that every supplemental baseline target built.
  • io_uring: workload and paired regression check succeeded.
  • Relay sessions: baseline compiled and began measurement, then panicked with Evicted.

Impact

  • Public API: none.
  • Wire: none.

Alternatives

Keep waiting for an entirely green Nightly. Dropped because the quest explicitly completes once a scheduled run gets past the base build; the broader Nightly epic remains open.

Decisions

Treat the verified baseline build as satisfying this wait quest. Do not claim that every paired comparison succeeded.

Validation

  • quest check --base origin/main: passed, 629 documents.
  • git diff --check origin/main: passed.
  • quest gate nix develop --ignore-environment --keep HOME --keep USER --keep PATH --command just ci origin/main: passed. The initial inherited-shell attempt failed in the unchanged Clippy fixture with mbx Argument list too long; the clean Nix environment resolved it without source changes.

Review

Claude Code, Claude Opus 5.5, medium effort, local quest review, round 2, head 5b41104123e75c34b0d5a5d1f56767e09e77e17f: no findings.

Round 1 requested proof of the scheduled baseline build. Fixed by recording the run, job links, exact build/measurement evidence, and remaining failures above. Round 2 accepted that evidence.

Follow-ups

The foreground should triage the Rust memory cancellation, relay Evicted panic, and supplemental baseline package mismatch against existing work. Paired regression calibration already belongs to bench CI. No follow-up quests were created here.

(Written by GPT-6.1 Sol)

kixelated and others added 2 commits November 1, 2026 17:50
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated kixelated changed the title The paired bench baseline builds chore(quest): finish paired benchmark baseline wait Nov 2, 2026
@kixelated
kixelated marked this pull request as ready for review November 2, 2026 01:53

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 5b41104123e75c34b0d5a5d1f56767e09e77e17f.

No actionable bugs found. Removing this narrowly scoped wait quest and its parent link is simpler than keeping it open until every Nightly failure is resolved. The remaining Nightly epic still requires an end-to-end passing scheduled run; this change introduces no runtime, API, or wire changes.

I independently checked scheduled run 41313466339 and the Rust bench job log: the baseline bench build finished at 14:15:28 UTC and criterion-base measurements subsequently ran, satisfying the deleted quest's explicit completion condition. The later memory benchmark cancellation does not establish successful comparison or a green Nightly.

Verification limits: static review of the two-file deletion and surrounding quest context, plus the cited GitHub run/log evidence. I did not run tests, builds, benchmarks, or quest validation.

(Written by OpenAI)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted quest/m0/nightly/bench-baseline-build.md — removes the completed wait quest in full; the file's own rule was to delete it once a scheduled run got past the base build.
  • Removed its parent link from quest/m0/nightly/README.md — drops the ## Required entry pointing at the deleted quest.

Docs-only quest housekeeping with no behavioral surface. git grep for bench-baseline-build across the tree returns nothing, so the deletion leaves no dangling references; the sibling browser-baseline link is a separate, still-open quest and is untouched. The PR body correctly scopes the completion criterion to "past the base build" and defers the remaining Nightly failures rather than overclaiming a green run.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b3d4ca33-e717-4376-b5b0-3aca1bd72c0d
Commits

Reviewing files that changed from the base of the PR and between 7c2d1dd and 5b41104.

Files selected for processing: 2
  • quest/m0/nightly/README.md
  • quest/m0/nightly/bench-baseline-build.md
Files with no reviewable changes: 2
  • quest/m0/nightly/README.md
  • quest/m0/nightly/bench-baseline-build.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The Nightly README no longer requires paired benchmark jobs to build and compare their baseline. The related quest document, which described the scheduled check, a suspected Cargo alias-merge issue, and a worktree fallback, was deleted.

Merge Risk: Minimal · up to 5b411

The paired baseline build passed, so removing the completed quest is mergeable. The later benchmark failures remain separate follow-ups.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies completion of the paired benchmark baseline wait, which matches the deleted quest and parent-link change.
Description check Passed The description directly explains the completed baseline-build blocker, the quest deletion, validation, evidence, and remaining Nightly failures.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@moq-bot
moq-bot Bot merged commit d52d55a into main Nov 2, 2026
1 check passed
@moq-bot
moq-bot Bot deleted the quest/m0/nightly/bench-baseline-build branch November 2, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant