Skip to content

chore(quest): plan dispatch.sh's tests passing without KVM - #7587

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/dispatch-test-kvm
Nov 2, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/dispatch-test-kvm

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans a fix for sh/dispatch-query.test.py, which fails 20 of its 30 tests on a Linux x86_64 host without /dev/kvm.

Changes

Decisions

  • Plan it in m0 ✅ / m1 / drop. It was decided in a /quest-plan interview on 2026-11-01. On such a host, every local just check on main fails today.

Impact

None. Quest files only.

Review

Codex gpt-6.1-sol (medium) via quest review --base origin/main, round 1 on e38748a2f72afcc0e5c910219368410fd5462336: no findings.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 31acdfde-5402-4476-a66f-37c08d8548ad
Commits

Reviewing files that changed from the base of the PR and between 5d5bd9b and e38748a.

Files selected for processing: 2
  • quest/m0/ci/README.md
  • quest/m0/ci/dispatch-test-kvm.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge (squash) November 2, 2026 00:00

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: e38748a

No actionable bugs found in this plan-only change. The direction addresses the actual test-isolation gap: the harness stubs commands but still reaches dispatch.sh's real /dev/kvm existence check. A narrow injectable probe is proportionate; keeping the production refusal and exercising both probe outcomes is preferable to skipping these tests or weakening the gate. No API/wire behavior changes here.

Verification: inspected both changed quest files, the dispatch KVM path, test harness and recent dispatch history. Static review only; no tests run, and the reported 20/30 failures were not independently reproduced.

(Written by OpenAI)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

A doc-only quest-plan PR: one new planning file plus its index entry. No code, wire, or public API change.

  • New quest quest/m0/ci/dispatch-test-kvm.md ([XS]) — plans making sh/dispatch-query.test.py pass on a Linux x86_64 host without /dev/kvm by having the test harness fake the probe, while keeping dispatch.sh's refusal and adding a case that asserts it.
  • CI epic index — quest/m0/ci/README.md gains the matching bullet linking the new quest.

The plan's central claim checks out. Forcing the check:flake KVM probe to refuse makes sh/dispatch-query.test.py report Ran 30 tests ... FAILED (failures=20), and reverting only that block restores a pass. The cited refusal is from #7281 (merged as 7273c68a4), and no existing quest duplicates this one.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@moq-bot
moq-bot Bot merged commit 1f27d41 into main Nov 2, 2026
@moq-bot
moq-bot Bot deleted the quest-plan/dispatch-test-kvm branch November 2, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant