Repository navigation
docs: allow bench-only backports to release - #7581
Conversation
`release` could only take a release cut or a fix backport, so a benchmark added on `main` could not join a pairing against `release` until the next cut. Allow bench-only backports: benchmarks and their harness, with no shipped code changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: e36aede6cc0d415ced0934743fe6e7b11701fa50
No actionable bugs found. The direction is appropriately narrow: permit benchmark-only backports while explicitly excluding shipped-code changes, preserving case IDs, and documenting omitted cases and release-plz consequences. Keeping the detailed policy in CONTRIBUTING.md avoids duplicating it in AGENTS.md. No API or wire changes.
Verification: static GitHub inspection of both changed documents and the surrounding benchmark/release guidance. Tests, builds, and benchmarks were not run.
(Written by GPT-6)
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Docs-only policy update permitting bench-only backports onto release.
AGENTS.md: the Development rule now reads "cut a release, backport a fix, or backport benchmarks".CONTRIBUTING.md: the Releases section defines a bench-only backport (benchmarks + harness only, no shipped code; local shims for APIsreleaselacks; case IDs kept identical tomainsojust bench origin/releasepairs them; omitted cases listed in the PR; release-plz patch bumps).
Verified against the tree: just bench [BASE] exists (justfile:49), bench/ is the harness, and the practice is already established by the #6103 bench backport referenced in quest/m1/release-perf/README.md. The AGENTS.md and CONTRIBUTING.md wording is consistent, and the two-line change introduces no behavioral surface.
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
Summary
AGENTS.mdallowed touchingreleaseonly to cut a release or backport a fix. So a benchmark added onmaincouldn't join a pairing againstreleaseuntil the next cut. The maintainer approved bench-only backports on 2026-11-01, in moq-dev/moq#7493: "I'm fine with bench only backports going forward".AGENTS.md:releasemay also take a bench backport.CONTRIBUTING.md(Releases) defines one: it carries only benchmarks and their harness (bench targets, bench-only dev-dependencies,bench/), and changes no shipped code. It shims locally any APIreleaselacks, and keeps each case ID the same as onmainsojust bench origin/releasepairs them. A case that measures codereleaselacks is left out and listed in the PR. Merging one makes release-plz propose patch bumps for the touched crates, as moq-dev/moq#6103 noted.Review
Skipped the local
quest reviewunder the simple-review rule, because this PR touches only docs. The online reviewers cover it.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)