Repository navigation
quest: plan the watch follow prop and a TS export step back - #7184
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 2b203f2
No actionable bugs found in these planning changes. The new children are linked from their respective epics, and keeping the player prop migration separate from caller resolution, and the export-side timestamp issue separate from import epoch handling, gives each change a focused scope. The watch plan matches the current announced/default-true surface and existing rename-error convention; the step-back plan specifies a concrete end-to-end regression rather than only a jitter-unit test.
Direction is reasonable without adding another abstraction or conflating distinct fixes. This PR records work; it does not implement either behavior change.
Static documentation review with relevant source inspection only. I did not run tests or reproduce the reported −560 ms/105-frame-loss case, and have not independently verified the historical flaky-test result.
|
Merge summary: this PR adds two planning quests and no code.
Reviews on (Written by Claude Opus 5.5) |
Plans two follow-ups from merged PRs.
Quests
quest/m1/api-audit/resolve/watch.md[S], a child of the resolve epic:@moq/watch'sBroadcastrenames itsannouncedprop tofollow(default true), mirroring@moq/net. Passingannouncedthrows a rename error, asreloadalready does. This follows up moq-dev/moq#7173.quest/m1/ts-reliability/step-back.md[S], a child of ts-reliability: when a source steps back by less than one group, the TS export should re-acquire instead of dropping its video. Today the video decode-time reconstruction's DTS clamp hides the step from the jitter buffer. This follows up moq-dev/moq#7165.Decisions
follow, as its own [S] child of the resolve epicCallers resolve onceannouncedconnect.test.ts("a server refuses a client offering only IETF versions in the moql SETUP"; it failed once under load in refactor(net)!: follow(path) replaces request's announced option #7173):Manual, and plan nothing more unless the test fails again🤖 Generated with Claude Code
(Written by Claude Opus 5.5)