Skip to content

quest: plan the watch follow prop and a TS export step back - #7184

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/watch-follow-flake-stepback
Oct 29, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/watch-follow-flake-stepback

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans two follow-ups from merged PRs.

Quests

  • quest/m1/api-audit/resolve/watch.md [S], a child of the resolve epic: @moq/watch's Broadcast renames its announced prop to follow (default true), mirroring @moq/net. Passing announced throws a rename error, as reload already does. This follows up moq-dev/moq#7173.
  • quest/m1/ts-reliability/step-back.md [S], a child of ts-reliability: when a source steps back by less than one group, the TS export should re-acquire instead of dropping its video. Today the video decode-time reconstruction's DTS clamp hides the step from the jitter buffer. This follows up moq-dev/moq#7165.

Decisions

  • Watch prop:
    • ✅ Rename to follow, as its own [S] child of the resolve epic
    • Fold it into Callers resolve once
    • Keep announced
  • Small step back:
    • ✅ A new ts-reliability quest, since step-restart covers only TS and SRT imports
    • Fold it into step-restart
    • Drop it
  • Flaky connect.test.ts ("a server refuses a client offering only IETF versions in the moql SETUP"; it failed once under load in refactor(net)!: follow(path) replaces request's announced option #7173):
    • ✅ Merge moq-dev/moq#7076, which converts that file's fake-timer tests to Manual, and plan nothing more unless the test fails again
    • A separate m0 test-flakes-2 child

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Follow-ups of #7173 (rename @moq/watch's `announced` prop to `follow`) and
#7165 (a sub-group step back drops the TS export's video).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ed229023-aadc-447f-8292-c7cf85f3734f
Commits

Reviewing files that changed from the base of the PR and between 5df6b85 and 2b203f2.

Files selected for processing: 4
  • quest/m1/api-audit/resolve/README.md
  • quest/m1/api-audit/resolve/watch.md
  • quest/m1/ts-reliability/README.md
  • quest/m1/ts-reliability/step-back.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T03:15:08.986875Z 2b203f2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 2b203f2

No actionable bugs found in these planning changes. The new children are linked from their respective epics, and keeping the player prop migration separate from caller resolution, and the export-side timestamp issue separate from import epoch handling, gives each change a focused scope. The watch plan matches the current announced/default-true surface and existing rename-error convention; the step-back plan specifies a concrete end-to-end regression rather than only a jitter-unit test.

Direction is reasonable without adding another abstraction or conflating distinct fixes. This PR records work; it does not implement either behavior change.

Static documentation review with relevant source inspection only. I did not run tests or reproduce the reported −560 ms/105-frame-loss case, and have not independently verified the historical flaky-test result.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: this PR adds two planning quests and no code.

  • quest/m1/api-audit/resolve/watch.md: the watch follow prop change, linked from the resolve epic.
  • quest/m1/ts-reliability/step-back.md: the TS export timestamp step-back fix with an end-to-end regression, linked from the ts-reliability epic.

Reviews on 2b203f2: a Codex 👍 and the automated OpenAI review, both with no findings. quest check and sh/markdown.sh check pass locally. No decisions were left open.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 68d36cc Oct 29, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/watch-follow-flake-stepback branch October 29, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant