Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .claude/skills/quest-grill/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
name: quest-grill
description: Settle open decisions through an interactive interview with the user. Use when the user invokes /quest-grill or wants unsettled thinking challenged before action.
---

Run `quest skill grill` and follow its output.
If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first.
7 changes: 0 additions & 7 deletions .claude/skills/quest-ready/SKILL.md

This file was deleted.

7 changes: 7 additions & 0 deletions .claude/skills/quest-review/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
name: quest-review
description: Review a PR's branch locally with the other vendor's model, then mark it ready for review.
---

Run `quest skill review` and follow its output.
If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first.
21 changes: 9 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,18 @@ Prefer a quest for work needing durable scope or coordination.

# Reviews

AI agents review pushes on their own, skipping ones they judge trivial.
Never explicitly request a review.
Before marking a PR ready for review, and before each push to a ready PR, run `/quest-review` on the committed branch after the local checks pass.
It uses `quest review` to have the other vendor's model review against the PR's base branch, with `REVIEW.md` read from that base.

For each finding:
The PR body's `## Review` section records the reviewer harness, model and effort, reviewed head SHA, and each finding's disposition, or a skip and its reason when the author judges the change too trivial to review.
A record naming the head being merged counts as the required review when the PR's author has write access to the repository.
Otherwise, or if the record is missing or stale, the merging session checks out the head and runs `/quest-review`, following `quest guide`'s rules for untrusted heads and review exemptions.

- If you don't agree with it, reply to the finding and move on.
- If it's a relatively easy improvement, fix it and push. Update the summary if needed.
Address online reviewers' findings already posted on the head when merging; never wait for or request an online review.
For each local or online finding:

Wait for a review from any reviewer other than Grok.
Codex (OpenAI) reacts with a thumbs up when it has no findings; that counts as a review.
An automated review posted from the maintainer's account also counts.
A push that gets no new review once CI finishes was judged trivial, so the earlier review still covers it.
Skipped or rate-limited reviews do not count.
For a fork with no automatic non-Grok review, ask the maintainer to arrange one.
Merge only when that review has no findings, or every finding is fixed or replied to.
- Refute findings you disagree with using evidence; reply to online findings on the PR.
- Fix findings you agree with, rerun checks, and review the new head locally before pushing. Update the summary if needed.

# Follow-ups

Expand Down
8 changes: 4 additions & 4 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
# The quest CLI, which also serves the quest guide and skills the stubs in
# .claude/skills call. Bump the rev to upgrade them.
quest = {
url = "github:kixelated/quest/21d2159d504295c629d545a126f0cefd6da80149";
url = "github:kixelated/quest/01d051cf5dca8cd29c664bf8bcbcab63cdc76445";
inputs.nixpkgs.follows = "nixpkgs";
inputs.flake-utils.follows = "flake-utils";
};
Expand Down
1 change: 0 additions & 1 deletion quest/m0/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ edge, which embeds moq-relay; it moved there on 2026-09-28.

## Required

- [Adopt local reviews](/quest/m0/local-review.md) - PRs are reviewed locally by the other vendor's model before they are pushed, and merging never waits on an online reviewer
- [Nightly passes on main](/quest/m0/nightly/README.md) - the scheduled Nightly passes end to end, so red means a new break
- [Release credential leaks](/quest/m0/security-audit/README.md) - tokens stay out of logs and outbound HTTP clients verify their peer, on `main` and `release`
- [Interop and Video pass on main](/quest/m0/interop-green/README.md) - the scheduled Interop and Video workflows pass, so red means a new break
Expand Down
26 changes: 0 additions & 26 deletions quest/m0/local-review.md

This file was deleted.

Loading