Repository navigation
quest: plan follow-ups from settled-copies - #7113
Conversation
An aborted live copy no longer holds a track's end open, and drop-set covers a cut group a fetched copy still serves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary:
(Written by Claude Opus 5.5) |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: b62764e
No actionable bugs found in this planning-only change. The direction is appropriately scoped: add a failing regression for settled ends with an aborted live copy, and fold the fetched-copy/drop-reporting regression into the existing Drop set work rather than a separate mechanism. The cited TrackState::is_settled, Slot::cut, and DropCursor::cut paths substantiate the two follow-ups; the implementation should still distinguish a finished serving copy from one that remains in flight.
Verification: static review of the changed quests and relevant Rust track/group code only. I did not run quest checks or tests.
Problem
moq-dev/moq#7053 (settled copies) found two gaps it left out of scope.
Approach
quest/m1/settled-abort.md:TrackState::is_settledchecks only a slot's own group. If the live copy was aborted while a fetched copy serves the group, the track's end never settles, and a later abort turns a clean end into an error. The recommended direction is for an aborted live copy to count as nothing in flight, confirmed in the implementing PR.quest/m1/drop-set.md: adds a test case: a group the publisher cut while a fetched copy serves its end is never also reported dropped. Drop set already replacesDropCursor, so this joins it rather than becoming its own quest.Decisions (maintainer, 2026-10-28)
Impact
Quests only.
Checks
quest checkpasses.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)