Skip to content

quest: plan follow-ups from settled-copies - #7113

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/settled-followups
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/settled-followups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

moq-dev/moq#7053 (settled copies) found two gaps it left out of scope.

Approach

  • [S] quest/m1/settled-abort.md: TrackState::is_settled checks only a slot's own group. If the live copy was aborted while a fetched copy serves the group, the track's end never settles, and a later abort turns a clean end into an error. The recommended direction is for an aborted live copy to count as nothing in flight, confirmed in the implementing PR.
  • quest/m1/drop-set.md: adds a test case: a group the publisher cut while a fetched copy serves its end is never also reported dropped. Drop set already replaces DropCursor, so this joins it rather than becoming its own quest.

Decisions (maintainer, 2026-10-28)

Impact

Quests only.

Checks

quest check passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

An aborted live copy no longer holds a track's end open, and drop-set
covers a cut group a fetched copy still serves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 10904020-5829-4364-99b1-b8e326177dba
Commits

Reviewing files that changed from the base of the PR and between b8a8b4e and b62764e.

Files selected for processing: 3
  • quest/m1/README.md
  • quest/m1/drop-set.md
  • quest/m1/settled-abort.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T16:23:26.878304Z b62764e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Quest-only PR: adds quest/m1/settled-abort.md, links it from quest/m1/README.md, and adds a test case to quest/m1/drop-set.md.
  • sh/markdown.sh check passes locally, and so does quest check --base origin/main.
  • Codex reviewed head b62764e with no findings (👍). CodeRabbit was rate-limited.
  • No decisions remain open. Landing head b62764e8ef031eb56bb6efa3a28b136172ca9ba5.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: b62764e

No actionable bugs found in this planning-only change. The direction is appropriately scoped: add a failing regression for settled ends with an aborted live copy, and fold the fetched-copy/drop-reporting regression into the existing Drop set work rather than a separate mechanism. The cited TrackState::is_settled, Slot::cut, and DropCursor::cut paths substantiate the two follow-ups; the implementation should still distinguish a finished serving copy from one that remains in flight.

Verification: static review of the changed quests and relevant Rust track/group code only. I did not run quest checks or tests.

Merged via the queue into main with commit 6f6cdd7 Oct 28, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/settled-followups branch October 28, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant