Skip to content

docs: align upgrade notes with supported behavior - #7064

Merged
kixelated merged 6 commits into
mainfrom
quest/m1/upgrade-guide-facts
Oct 29, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m1/upgrade-guide-facts

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The upgrade notes promise unsupported moq-transport drafts and capped auth roles, and the CLI migration notes say a removed environment variable is ignored even though it stops startup.

Approach

Match the notes to the current Rust and JavaScript version declarations, pattern-array auth roles, and both binaries' environment validation. Correct the same removed-variable behavior in the relay migration guide and complete the owning quest.

Impact

  • Public API and MoQ wire: unchanged. Documentation only.

Alternatives

Keep the existing strict behavior and correct its documentation; no production compatibility policy changes are needed.

Validation

  • Verified the factual claims against the Rust/JS IETF versions, auth role deserialization, and CLI/relay check_env calls.
  • Repository-wide documentation and migration-guide search found no other removed MOQ_* variables described as ignored.
  • Full just ci passed on 8bbd822a03: 674 native tests passed, 25 existing skips; selected Rust feature/clippy, JavaScript, Markdown, workflow tests, drill mutation, quest, shell, TOML, Nix, and justfile checks passed.
  • The gate validated 616 quest documents, and git diff --check passed.
  • Latest main merged without conflicts. No unfinished validation or design decisions remain.

Follow-ups

None.

(Written by GPT-6)

kixelated and others added 3 commits October 28, 2026 00:33
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@kixelated kixelated changed the title Upgrade notes match the code docs: align upgrade notes with supported behavior Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 28, 2026 16:39
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3612f1a4-bd89-4887-9433-6e24d877086f
Commits

Reviewing files that changed from the base of the PR and between 4f7f7c4 and 373576e.

Files selected for processing: 5
  • doc/setup/upgrade.md
  • quest/m1/README.md
  • quest/m1/upgrade-guide-facts.md
  • rs/moq-cli/MIGRATE.md
  • rs/moq-relay/MIGRATE.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T05:53:48.434947Z 373576e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 8bbd822

No actionable bugs found. The corrected draft list matches both Rust and JavaScript version declarations; pattern-array roles match auth deserialization; and the CLI/relay startup paths reject undeclared MOQ_* variables. Correcting the documentation rather than adding compatibility exceptions is the simpler, appropriate direction, and the completed quest removal matches this scope.

Verification: static review of the five-file diff and relevant version, auth, and environment-validation code. I did not run tests or independently reproduce the PR's reported CI results.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main twice (both conflict-free; head 373576e). Holding the merge on one question: the draft list depends on which PR lands first.

  • moq-dev/moq#7190 restores draft 20 but hasn't landed. It conflicts with main and has an unresolved Codex thread. It also rewrites quest/m1/upgrade-guide-facts.md, which this PR deletes.
  • Main ships drafts 18 and 22, so this PR's doc/setup/upgrade.md correctly says "18 and 22" today. If it lands first, feat(net): bring back moq-transport draft 20 #7190 gets a modify/delete conflict and has to add draft 20 to that bullet itself.
  • The IETF narrowing planned in moq-dev/moq#7194 (one-group FETCH and fills, FILL_TIMEOUT ignored, SUBSCRIBE_TRACKS refused) hasn't landed. The upgrade notes describe neither it nor the current range-serving publisher, so nothing there needs to change.

Recommended: land #7190 first, then merge main here (keep the quest deletion) and list drafts 18, 20 and 22.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing at 373576e.

  • Reviews: Codex had no findings on this head (thumbs up). The commits since the automated review are conflict-free merges from main.
  • quest check --base origin/main passes: the quest is deleted along with its link in quest/m1/README.md.
  • Ordering with moq-dev/moq#7190: I'm landing this one first. Main ships drafts 18 and 22 today, so "18 and 22" is correct now. feat(net): bring back moq-transport draft 20 #7190 is still conflicting and doesn't touch doc/setup/upgrade.md. When it merges main, it will hit a modify/delete conflict on quest/m1/upgrade-guide-facts.md. To resolve it, keep the deletion and add draft 20 to the drafts bullet in doc/setup/upgrade.md.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit c229fe4 Oct 29, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/upgrade-guide-facts branch October 29, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant