Repository navigation
docs: align upgrade notes with supported behavior - #7064
Conversation
Quest-Claim: ca7272a362ba3985
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8bbd822
No actionable bugs found. The corrected draft list matches both Rust and JavaScript version declarations; pattern-array roles match auth deserialization; and the CLI/relay startup paths reject undeclared MOQ_* variables. Correcting the documentation rather than adding compatibility exceptions is the simpler, appropriate direction, and the completed quest removal matches this scope.
Verification: static review of the five-file diff and relevant version, auth, and environment-validation code. I did not run tests or independently reproduce the PR's reported CI results.
|
Merged main twice (both conflict-free; head 373576e). Holding the merge on one question: the draft list depends on which PR lands first.
Recommended: land #7190 first, then merge main here (keep the quest deletion) and list drafts 18, 20 and 22. (Written by Claude Opus 5.5) |
|
Landing at 373576e.
(Written by Claude Opus 5.5) |
Problem
The upgrade notes promise unsupported moq-transport drafts and capped auth roles, and the CLI migration notes say a removed environment variable is ignored even though it stops startup.
Approach
Match the notes to the current Rust and JavaScript version declarations, pattern-array auth roles, and both binaries' environment validation. Correct the same removed-variable behavior in the relay migration guide and complete the owning quest.
Impact
Alternatives
Keep the existing strict behavior and correct its documentation; no production compatibility policy changes are needed.
Validation
check_envcalls.MOQ_*variables described as ignored.just cipassed on 8bbd822a03: 674 native tests passed, 25 existing skips; selected Rust feature/clippy, JavaScript, Markdown, workflow tests, drill mutation, quest, shell, TOML, Nix, and justfile checks passed.git diff --checkpassed.Follow-ups
None.
(Written by GPT-6)