Skip to content

chore(quest): finish draft-18 tail validation - #7059

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/interop-green/tail-empty-group
Oct 29, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/interop-green/tail-empty-group

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The M0 interop quest tracked an empty group when a Rust tail subscriber joined a Node or Bun publisher over moq-transport-18. Its previous checkpoint could not run the reproduction because the host was busy.

Approach

Validate updated main at b8a8b4ef70. The existing implementation passes the original tail assertions on drafts 18 and 22, including both Node and Bun publishers delivering groups 0 through 3 and a clean end to Rust. Remove the completed quest and its epic link. Production code and test assertions are unchanged.

Impact

  • Public API and wire: unchanged.
  • The tail investigation is complete with passing current-main evidence.

Alternatives

The existing implementation passes the required reproduction, so completing the investigation needs no additional protocol change.

Validation

  • quest gate just test interop --tail --versions ietf: passed, all 34 matrix checks across drafts 18 and 22, including both original failing directions, datagrams, TRACK_STATUS, GOAWAY and CLI FETCH controls.
  • The command's 9 Rust/JS wire and session interop prerequisites passed.
  • quest gate just ci: passed on the final quest removal, including Markdown, workflow checks/tests, quest, shell, large-file, TOML, Nix and justfile checks.
  • quest check --base origin/main: 616 documents passed. Diff checks passed.
  • Harness logs are retained locally under .tmp/runs/interop-s2bP8Dwb/; its children were reaped and ports released.

Follow-ups

None outside this quest. Nothing is merged or enqueued.

(Written by GPT-6)

@kixelated kixelated changed the title Draft-18 tail ends cleanly fix(net): investigate draft-18 finite tail groups Oct 28, 2026
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated kixelated changed the title fix(net): investigate draft-18 finite tail groups docs(quest): checkpoint draft-18 tail validation Oct 28, 2026
@kixelated kixelated changed the title docs(quest): checkpoint draft-18 tail validation chore(quest): finish draft-18 tail validation Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 28, 2026 16:35
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de0bdac3-c080-4901-ad0a-c4023f5d9b21
Commits

Reviewing files that changed from the base of the PR and between b8a8b4e and 9cdc024.

Files selected for processing: 2
  • quest/m0/interop-green/README.md
  • quest/m0/interop-green/tail-empty-group.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T16:36:12.434283Z 9cdc024 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 9cdc024

No actionable bugs found in this documentation-only completion. Removing the tail quest and its epic link is consistent with its stated completion criterion and the reported current-main reproduction; retaining the epic's separate scheduled Interop/Video confirmation avoids declaring the broader effort complete. No protocol change or added complexity is warranted here.

Verification: inspected both changed files and the unchanged Rust/JS tail assertions and harness wiring for both Node and Bun. The strict payload, group-set and clean-end checks remain intact. I did not run tests or independently verify the locally retained passing-run logs; the reported passes are author-provided evidence.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: no changes were needed on this PR. CI is green on head 9cdc024 (12/12), mergeable and clean against main. The automated review from the maintainer's account and Codex's 👍 both cover this head with no findings, and there are no unresolved threads. quest check --base origin/main --branch quest/m0/interop-green/tail-empty-group passes (616 documents) on this head, and the README link this PR removes was the only link to the deleted quest. No decisions were outstanding. Landing via the merge queue (squash).

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit a2579a4 Oct 29, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m0/interop-green/tail-empty-group branch October 29, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant