You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(obs): disable simulcast rungs the grant cannot fund - #7029
Quest: quest/m1/simulcast-rung-disable.md. This PR lands the OBS rung disable and rewrites the quest to the remaining shaped-uplink proof.
Summary
OBS follows the shared rule instead of mirroring it.cpp/obs/src/moq-rate.h (a C++ copy of moq_mux::rate::Control without the rung rule) and its test are deleted. Each retunable video encoder follows its reservation through moq-ffi's new MoqRateControl, which wraps moq_mux::rate::Control and reads both the grant and whether a session probes for it.
Ladder from the output's encoders. Every video encoder on the output encodes the same program. An encoder's lower rendition is the one with the next lower configured bitrate. That track is published first (recursively), so the higher one sits one track priority below it and the allocator funds the lower one first.
Disable and resume. A Disabled target marks a discontinuity (once the track has written a frame), sets the catalog enabled: false, and drops the encoder's packets. OBS cannot stop one encoder of a live output or force it to keyframe. After an Enabled target, the rung resumes at the encoder's next natural keyframe with enabled: true. Stop restores the configured bitrate whenever the applied one moved.
FFI (rs/moq-ffi):
MoqRateControl / MoqRatePolicy { max_bps, lower_bps } / MoqRateTarget { Enabled { bitrate_bps }, Disabled }. update(&MoqReservation) feeds the current grant and probe state on the ambient clock, for a sender that is driven per frame.
MoqVideoInit.lower: Option<MoqMediaTrackProducer> publishes a pre-encoded track one priority below the lower video track. A lower audio track is refused.
MoqMediaTrackProducer::set_enabled(bool) flips the catalog enabled of a video track. An audio track refuses.
moq-mux: import::VideoInit.priority (defaults to PRIORITY.video), import::Track::set_enabled (video only, Error::WrongKind for audio), and set_enabled on the AV1, VP8, and VP9 importers, matching H.264/H.265.
Bindings: Python (RateControl, RateTarget, TrackProducer.set_enabled, lower= on both video importers), Swift (same), Go (RateControl, RatePolicy, RateTarget*, TrackProducer.SetEnabled, and media.VideoInit as a struct with Lower *TrackProducer), Kotlin and Dart aliases, and regenerated Dart bindings. doc/lib/* and doc/bin/obs.md describe the pre-encoded path and the OBS ladder.
Quest: rewritten to the shaped-uplink proof. BBR3 aging has since landed, so it has no Required; its Plan uses main's rate-stepping moq-shaper profiles (cellular-step). Summaries in quest/m1/README.md and quest/m2/probe/README.md are updated.
Impact
Wire: none (enabled is already in the catalog).
Additive, FFI: MoqRateControl, MoqRatePolicy, MoqRateTarget, MoqMediaTrackProducer::set_enabled, and MoqVideoInit.lower (UniFFI default None; nullptr in C++).
Additive, moq-mux: import::VideoInit::priority (the struct is #[non_exhaustive] with a constructor), import::Track::set_enabled, and {av1,vp8,vp9}::Import::set_enabled.
Breaking, Go wrapper: media.VideoInit is a struct rather than an alias of the generated record. Composite literals with Format, Data, Label, and Hint compile unchanged. A MIGRATE note is added.
Behavior, OBS: with several video encoders, a higher one now publishes at a lower track priority and stops sending while its grant cannot fund it. With one encoder, nothing changes.
Not changed: the C ABI (rs/moq-c, c/moq). OBS uses the generated moq-ffi package, so nothing consumes a C equivalent yet (see decision 4).
Decisions settled
The maintainer accepted every recommendation in a /quest-complete session:
Rate rule for OBS: MoqRateControl in moq-ffi wraps moq_mux::rate::Control, replacing the C++ MoQRate mirror (done here).
Pre-encoded track priority: the MoqVideoInit.lower handle, matching MoqVideoProducerOptions.lower, not an explicit priority (done here). MoqMediaTrackStreamProducer::video accepts lower too, but a stream producer cannot itself be passed as one.
Only retunable encoders disable: a rung needs OBS_ENCODER_CAP_DYN_BITRATE and CBR/VBR/ABR to get a RateControl. A CQP/CRF or non-retunable top encoder still sits one priority below its lower one but never disables.
C ABI parity: left to a follow-up quest until a C consumer needs it.
Choices made
Disabled packets are dropped and the rung resumes at the encoder's next natural keyframe, rather than restarting the encoder. OBS cannot stop or keyframe one encoder of an active output, so the resume waits up to one keyframe interval.
The lower rendition's ceiling is the configured bitrate that rendition recorded at init, not its live settings, which the grant may already have retuned.
MoqRateControl::update takes the reservation, not a grant plus a probe flag, so a caller can't forget the probe gate. MoqReservation::probed therefore stays unexported.
A rung disabled before its first frame skips the discontinuity marker. The marker resets the splitter, which still holds the extra data's SPS/PPS until a keyframe adopts them, and an encoder that sends headers only as extra data (OBS's x264) never repeats them. There is no timeline to break yet anyway.
The OBS ladder test drives Retarget directly with no encoder following. A localhost session's real grant would otherwise move the targets mid-test. The rule itself is covered by moq_mux::rate's tests and model.
Follow-ups
C ABI rung disable for pre-encoded media (decision 4): moq_publish_media_set_enabled, the media track's lower/priority, and a C rate control over moq_reservation, with doc/lib/c.
Raw-stream simulcast rungs: MoqMediaTrackStreamProducer can't be passed as a lower, and it has no set_enabled, so a ladder made only of byte-stream producers can't link priorities or disable a rung. Parity needs the stream producer to record its priority, to export set_enabled, and a lower type that accepts either producer. Raised by CodeRabbit (r4436515610).
Checks
On head b4dff1fa37 (main at 622d7bc0c5 merged):
just ci origin/main (inside nix develop, via quest gate) on 95ce36573e: every module passed (check rs, test rs, check py, test py, check c, check cpp, check obs_compile, check go, check kt, check js, test js, and the lint modules). check dart failed because the merged generated bindings were stale. 0238c502f2 regenerates them, and check dart then passes. Swift was skipped locally because Linux has no Swift toolchain.
b4dff1fa37 is a conflict-free merge of origin/main that touches only moq-quic, moq-uring, quest files, and the lockfile. None of these overlap this PR.
quest check --base origin/main: ok.
just obs test (TSan) on c672fbec30: every MoQOutput, moq_source, and settings test passes. The only cpp/obs change since is main's 01c6e7e80f (CMake qlog option), and check obs_compile and check cpp pass on the merged tree.
Land history
16:36Z merge_conflict (MIGRATE.md, Kotlin aliases, quest Plan, Swift Media.swift): resolved here. Main's moq-dev/moq#7319 formatting gates reflowed the Swift and Kotlin, and main's moq-dev/moq#7334 made moq-shaper step its rate, so the quest Plan now uses that instead of asking for it.
The land fixer pushed an equivalent merge (0b4f430067) at 16:41Z; this branch merges it with -s ours (same parents, this resolution kept) rather than force-pushing.
16:55Z batch test rs failed (exit 101) on 0b4f430067. The posted log is truncated before nextest's summary, so the failing test is not visible. test rs passes locally on the same tree content and on the newer base three times, so it looks like a flake or another batch member.
18:15Z iterate: CI on dc718e72c4 passed (5/5), and after this branch merged main at 951cca678c the full local just ci gate passed, test rs included. Nothing on this branch reproduces the batch failure, so the code is unchanged. The CodeRabbit thread on rs/moq-ffi/src/media.rs:375 is refuted (reply) and listed under Follow-ups.
2026-11-02 iterate: auto-merge was disabled (it had been enabled at 40abd59716 under the old landing flow, and the PR has conflicted with main since). Main has no equivalent change (moq-rate.h and the quest are still there), so the PR still applies. Merged origin/main (41f60ec46e). go/wrapper/MIGRATE.md keeps both entries, this PR's media.VideoInit note and main's moq-dev/moq#7484 captures note. py/moq-rs/moq/types.py keeps RateTarget and takes main's move of Range (main now imports it with Timestamp). The Dart bindings were regenerated (0238c502f2), and main was merged again at 622d7bc0c5 (conflict-free). No new automated review findings were posted since the last iterate, and the one CodeRabbit thread stays refuted.
Review
Reviewer: Codex (quest review), gpt-6.1-sol, medium effort, new session 01a19f99 (the whole branch against origin/main at 622d7bc0c5). The previous session 01a19810 is keyed to a local branch that another worktree has checked out, so this one starts fresh and reviews everything.
Round 1 on 95ce36573ef9ac9bace677e19df2f31530999dfa: no findings.
Round 2 on b4dff1fa3762ecb94935cdc5fcd0591818442c90 (the regenerated Dart bindings and a conflict-free merge of main): no findings.
Earlier sessions: Codex, gpt-6.1-sol, medium. Session 01a19810 round 1 on c672fbec30: none. Session 01a195f3 round 1 on d7e63636f6: none. Session 01a19158 on 11481709 found one issue, fixed in 92046c6bfd, then none. CodeRabbit's cpp/obs/src/moq-output.cpp:694 finding was fixed in a7959e2e74, and its doc/bin/obs.md:49 finding in 11481709. Its rs/moq-ffi/src/media.rs:375 finding (a raw-stream producer as lower) is refuted on decision 2 (reply), and CodeRabbit withdrew it. It is listed under Follow-ups.
OBS follows each video encoder's grant through moq-ffi's new MoqRateControl,
the same moq_mux::rate::Control the native publishers use, replacing the C++
MoQRate mirror. A rung above a lower encoder sits one track priority below it
(MoqVideoInit.lower), drops its packets while disabled (catalog enabled=false
via MoqMediaTrackProducer::set_enabled), and resumes at the next keyframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Python, Swift, and Go wrap MoqRateControl, MediaTrackProducer.set_enabled,
and the video init's lower rendition; Kotlin and Dart alias them. The docs
describe the pre-encoded path and the OBS ladder, and the quest is rewritten
to the remaining shaped-uplink proof, which requires BBR3 aging.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
OBS disables simulcast rungs the grant cannot fund, proven on a shaped uplink
feat(obs): disable simulcast rungs the grant cannot fund
Oct 28, 2026
The change adds reservation-based rate control with enabled or disabled sender targets and optional lower-rendition bitrate policies. Video producer APIs can link renditions to set relative priority and change a track’s advertised enabled state. Rust FFI and language bindings expose these APIs. OBS applies rate targets to encoders, initializes linked tracks in dependency order, and resumes disabled tracks on keyframes. Tests cover rendition priority, disablement, and resumption.
Merge Risk: Moderate · up to 0b4f4
Raw-stream simulcast ladders cannot use the new linked-priority behavior, and a failed OBS resume can leave a rendition advertised as available. Resolve these issues before merging.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 62.96% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary change: disabling simulcast rungs when their grant cannot fund them.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description is clearly related to the changeset. It names the quest document it lands against and explains that the OBS C++ rate copy (cpp/obs/src/moq-rate.h and its test) is removed in favor of m…
Full details: Description check
Explanation
The description is clearly related to the changeset. It names the quest document it lands against and explains that the OBS C++ rate copy (cpp/obs/src/moq-rate.h and its test) is removed in favor of moq-ffi's MoqRateControl. It also covers the ladder and disable/resume logic in the OBS output, the new moq-ffi, moq-mux, and binding APIs (Python, Swift, Go, Kotlin, Dart), the Go VideoInit struct change, and the documentation updates. These match the raw summary. The description also lists decisions, test runs, and review history, which adds detail beyond what the check requires.
Full details: Docstring Coverage
Explanation
Docstring coverage is 62.96% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 27 functions across 21 files. (4 skipped: 4 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Files skipped from review as they are similar to previous changes: 2
quest/m1/README.md
go/wrapper/MIGRATE.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
No actionable bugs found in the OBS disable/resume path, lower-rendition priority propagation, mux enabled setters, or the FFI/wrapper changes. The discontinuity path preserves cached codec parameters while clearing partial frames, and OBS waits for a natural keyframe before advertising the rung enabled again.
Direction: replacing the duplicated C++ rate rule with the shared Rust control is a good simplification. Keeping the configured ceiling separate from the applied bitrate also makes stop-time restoration and ladder discovery clearer. The deferred shaped-uplink proof remains important: the targeted OBS test drives Retarget directly, so it does not establish the complete grant/probe/encoder feedback loop or BBR3 recovery behavior.
Verification: static GitHub review of the changes and relevant surrounding code, including an independent FFI/bindings pass. No tests, binding builds, real OBS runs or shaped-network experiments performed; reported validation was not independently reproduced.
A higher rung's first packet started its lower rung's track, before an
encoder that supplies parameter sets only after its first frame had them,
so the lower track was cached without them. Wait for the lower's own first
packet instead, and open every track on a keyframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The direct two-rung startup case reported in #7029 (comment) is addressed, with focused header-readiness and initial-keyframe coverage. Deferring publication is the right direction, but one P2 remains inline: recursive deferral must propagate through a three-rung ladder rather than permanently publishing the top rung without its lower relation.
GitHub-only static delta and surrounding-code/test review. No OBS tests, builds, binding checks, or shaped-uplink experiments were run. The remaining end-to-end bandwidth proof is not established by the targeted fixture.
Prior P2 fixed: the recursive startup-deferral finding is addressed. After recursive initialization, an absent lower track now defers its caller too, so the top rung cannot be cached without its lower relation. The expanded 8/4/2 Mbps fixture delays the bottom headers and verifies both priority steps once startup resumes. The earlier direct two-rung header fix remains intact.
No new actionable bugs found in this delta. The narrow propagation check is a sound, simpler fix than repairing already-published tracks. Compared against the previous reviewed commit 20a56a3; the only intervening commit changes this check and its regression fixture.
Verification: static GitHub delta and surrounding VideoInit/VideoData/test review. No OBS tests, builds, binding checks or shaped-uplink experiments were run; the fixture does not establish the deferred end-to-end grant/probe/encoder feedback proof.
Merged main and resolved the conflicts: MediaProducer keeps the PR's video priority but drops its cached demand, since main now reads demand() from the importer each time (#7110). Kept both MIGRATE.md entries and both new moq-ffi tests, and regenerated the Dart bindings. The quest drops its BBR3-aging blocker, which #7017 landed.
Codex finding (r4414612631): a higher rung no longer starts its lower rung's track before the lower encoder has its headers. It waits for the lower's first packet, and every video track opens on a keyframe.
Follow-up finding (r4419539590): that wait now carries up the whole ladder. The test covers an 8/4/2 ladder with the bottom headers delayed.
Ran locally: the OBS unit tests (plain), cargo test/clippy -D warnings for moq-ffi, cargo fmt, clang-format, and quest check.
The old GitHub merge queue ejected ba63bd17c7 as merge_conflict. Merged main (80cafb3afe) locally. Git resolved every overlap, including the quest link lists, so no conflict was hand-resolved. The regenerated Dart bindings (just dart generate) match the merged moq.dart exactly.
Ran locally: cargo nextest run -p moq-mux -p moq-ffi (2158 passed), just go check, and quest check --base origin/main.
Codex reviewed the merged head (quest review, gpt-6.1-sol, medium) and found nothing. The body's ## Review records it.
codex / Codex land fixer: This maintainer pick already used its mechanical fi·x attempt. Run /quest-iterate to diagnose the repeated failure, then pick it again.
Both merge e8f805a with 802cadc; keep this branch's resolution (swift-format layout, combined shaper bullet).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No new actionable defects found. OBS behavior, rate policy and regression tests remain unchanged. The regenerated Dart disposal allocates status before marking the object disposed and detaching its finalizer, preserving ownership if allocation fails; the remaining changes are largely base adaptations and formatting.
Verification: static GitHub comparison and wrapper inspection only; no builds or tests run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kixelated
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
kixelated
left a comment
Quest: quest/m1/simulcast-rung-disable.md. This PR lands the OBS rung disable and rewrites the quest to the remaining shaped-uplink proof.
Summary
cpp/obs/src/moq-rate.h(a C++ copy ofmoq_mux::rate::Controlwithout the rung rule) and its test are deleted. Each retunable video encoder follows its reservation through moq-ffi's newMoqRateControl, which wrapsmoq_mux::rate::Controland reads both the grant and whether a session probes for it.Disabledtarget marks a discontinuity (once the track has written a frame), sets the catalogenabled: false, and drops the encoder's packets. OBS cannot stop one encoder of a live output or force it to keyframe. After anEnabledtarget, the rung resumes at the encoder's next natural keyframe withenabled: true. Stop restores the configured bitrate whenever the applied one moved.rs/moq-ffi):MoqRateControl/MoqRatePolicy { max_bps, lower_bps }/MoqRateTarget { Enabled { bitrate_bps }, Disabled }.update(&MoqReservation)feeds the current grant and probe state on the ambient clock, for a sender that is driven per frame.MoqVideoInit.lower: Option<MoqMediaTrackProducer>publishes a pre-encoded track one priority below the lower video track. A lower audio track is refused.MoqMediaTrackProducer::set_enabled(bool)flips the catalogenabledof a video track. An audio track refuses.import::VideoInit.priority(defaults toPRIORITY.video),import::Track::set_enabled(video only,Error::WrongKindfor audio), andset_enabledon the AV1, VP8, and VP9 importers, matching H.264/H.265.RateControl,RateTarget,TrackProducer.set_enabled,lower=on both video importers), Swift (same), Go (RateControl,RatePolicy,RateTarget*,TrackProducer.SetEnabled, andmedia.VideoInitas a struct withLower *TrackProducer), Kotlin and Dart aliases, and regenerated Dart bindings.doc/lib/*anddoc/bin/obs.mddescribe the pre-encoded path and the OBS ladder.Required; its Plan uses main's rate-steppingmoq-shaperprofiles (cellular-step). Summaries inquest/m1/README.mdandquest/m2/probe/README.mdare updated.Impact
enabledis already in the catalog).MoqRateControl,MoqRatePolicy,MoqRateTarget,MoqMediaTrackProducer::set_enabled, andMoqVideoInit.lower(UniFFI defaultNone;nullptrin C++).import::VideoInit::priority(the struct is#[non_exhaustive]with a constructor),import::Track::set_enabled, and{av1,vp8,vp9}::Import::set_enabled.media.VideoInitis a struct rather than an alias of the generated record. Composite literals withFormat,Data,Label, andHintcompile unchanged. A MIGRATE note is added.rs/moq-c,c/moq). OBS uses the generated moq-ffi package, so nothing consumes a C equivalent yet (see decision 4).Decisions settled
The maintainer accepted every recommendation in a /quest-complete session:
MoqRateControlin moq-ffi wrapsmoq_mux::rate::Control, replacing the C++MoQRatemirror (done here).MoqVideoInit.lowerhandle, matchingMoqVideoProducerOptions.lower, not an explicitpriority(done here).MoqMediaTrackStreamProducer::videoacceptslowertoo, but a stream producer cannot itself be passed as one.OBS_ENCODER_CAP_DYN_BITRATEand CBR/VBR/ABR to get aRateControl. A CQP/CRF or non-retunable top encoder still sits one priority below its lower one but never disables.Choices made
MoqRateControl::updatetakes the reservation, not a grant plus a probe flag, so a caller can't forget the probe gate.MoqReservation::probedtherefore stays unexported.Retargetdirectly with no encoder following. A localhost session's real grant would otherwise move the targets mid-test. The rule itself is covered bymoq_mux::rate's tests and model.Follow-ups
moq_publish_media_set_enabled, the media track's lower/priority, and a C rate control overmoq_reservation, withdoc/lib/c.MoqMediaTrackStreamProducercan't be passed as alower, and it has noset_enabled, so a ladder made only of byte-stream producers can't link priorities or disable a rung. Parity needs the stream producer to record its priority, to exportset_enabled, and alowertype that accepts either producer. Raised by CodeRabbit (r4436515610).Checks
On head
b4dff1fa37(main at622d7bc0c5merged):just ci origin/main(insidenix develop, viaquest gate) on95ce36573e: every module passed (check rs,test rs,check py,test py,check c,check cpp,check obs_compile,check go,check kt,check js,test js, and the lint modules).check dartfailed because the merged generated bindings were stale.0238c502f2regenerates them, andcheck dartthen passes. Swift was skipped locally because Linux has no Swift toolchain.b4dff1fa37is a conflict-free merge oforigin/mainthat touches onlymoq-quic,moq-uring, quest files, and the lockfile. None of these overlap this PR.quest check --base origin/main: ok.just obs test(TSan) onc672fbec30: every MoQOutput, moq_source, and settings test passes. The onlycpp/obschange since is main's01c6e7e80f(CMake qlog option), andcheck obs_compileandcheck cpppass on the merged tree.Land history
merge_conflict(MIGRATE.md, Kotlin aliases, quest Plan, SwiftMedia.swift): resolved here. Main's moq-dev/moq#7319 formatting gates reflowed the Swift and Kotlin, and main's moq-dev/moq#7334 mademoq-shaperstep its rate, so the quest Plan now uses that instead of asking for it.0b4f430067) at 16:41Z; this branch merges it with-s ours(same parents, this resolution kept) rather than force-pushing.test rsfailed (exit 101) on0b4f430067. The posted log is truncated before nextest's summary, so the failing test is not visible.test rspasses locally on the same tree content and on the newer base three times, so it looks like a flake or another batch member.dc718e72c4passed (5/5), and after this branch merged main at951cca678cthe full localjust cigate passed,test rsincluded. Nothing on this branch reproduces the batch failure, so the code is unchanged. The CodeRabbit thread onrs/moq-ffi/src/media.rs:375is refuted (reply) and listed under Follow-ups.40abd59716under the old landing flow, and the PR has conflicted with main since). Main has no equivalent change (moq-rate.hand the quest are still there), so the PR still applies. Mergedorigin/main(41f60ec46e).go/wrapper/MIGRATE.mdkeeps both entries, this PR'smedia.VideoInitnote and main's moq-dev/moq#7484 captures note.py/moq-rs/moq/types.pykeepsRateTargetand takes main's move ofRange(main now imports it withTimestamp). The Dart bindings were regenerated (0238c502f2), and main was merged again at622d7bc0c5(conflict-free). No new automated review findings were posted since the last iterate, and the one CodeRabbit thread stays refuted.Review
quest review), gpt-6.1-sol, medium effort, new session01a19f99(the whole branch againstorigin/mainat622d7bc0c5). The previous session01a19810is keyed to a local branch that another worktree has checked out, so this one starts fresh and reviews everything.95ce36573ef9ac9bace677e19df2f31530999dfa: no findings.b4dff1fa3762ecb94935cdc5fcd0591818442c90(the regenerated Dart bindings and a conflict-free merge of main): no findings.01a19810round 1 onc672fbec30: none. Session01a195f3round 1 ond7e63636f6: none. Session01a19158on11481709found one issue, fixed in92046c6bfd, then none. CodeRabbit'scpp/obs/src/moq-output.cpp:694finding was fixed ina7959e2e74, and itsdoc/bin/obs.md:49finding in11481709. Itsrs/moq-ffi/src/media.rs:375finding (a raw-stream producer aslower) is refuted on decision 2 (reply), and CodeRabbit withdrew it. It is listed under Follow-ups.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)