Skip to content

quest: plan the 2026-10-27 refactor audit's new findings - #7008

Merged
kixelated merged 3 commits into
mainfrom
quest-plan/refactor-audit
Oct 29, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest-plan/refactor-audit

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Plans the findings from a 2026-10-27 refactoring audit that no quest owns yet. All new quests go in m2.

New quests

Already owned, not re-planned

Decisions

Round 1

  1. Bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 in /server #9: What should the shared @moq/ui consolidation quest (m2) cover?
    • Fullscreen + formatters (recommended)
    • ✅ Also stats primitives
    • Skip
  2. Bump json5 from 2.2.1 to 2.2.3 in /player #8: How should the watch audio/video support probe be shared (m2)?
    • Helper, no audio error (recommended)
    • ✅ Helper + audio error
    • Skip
  3. Bump golang.org/x/crypto from 0.0.0-20211117183948-ae814b36b871 to 0.1.0 in /server #6: What TrackState work should be quested?
    • ✅ Publication enum only (recommended)
    • Broader invariant split
    • Skip
  4. Bump golang.org/x/text from 0.3.7 to 0.3.8 in /cert #4 and WebCodecs #10: Which low-value items should still get a quest? (multi-select; none was recommended)

Round 2

  1. Bump golang.org/x/text from 0.3.7 to 0.3.8 in /cert #4: May the settings quest post the single-declaration proposal on jdx/usage?
    • Approve posting (recommended)
    • ✅ Ask before posting
  2. Bump json5 from 2.2.1 to 2.2.3 in /player #8: What consumes the new audio NotSupportedError?
    • ✅ Unsupported indicator (recommended)
    • API only
  3. WebCodecs #10: What shape should the dispatcher's module descriptor take?
    • ✅ Bash registration (recommended)
    • Port to Python

Impact

Quest files only. No public API or wire change.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 71c7c5cd-9aa3-451f-b3f7-8296598d2f3f
Commits

Reviewing files that changed from the base of the PR and between 66bdbb9 and 1e1aac4.

Files selected for processing: 6
  • quest/m2/README.md
  • quest/m2/dispatch-modules.md
  • quest/m2/track-publication-state.md
  • quest/m2/ui-shared-controls.md
  • quest/m2/usage-settings-once.md
  • quest/m2/watch-support-probe.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T15:25:09.062196Z 1e1aac4 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 263775a

No actionable bugs found in this plan-only change. The direction is appropriately narrow: share support-probe mechanics without merging rendition selection, extract UI primitives without moving metric ownership, and replace only publication flags rather than splitting all of TrackState. Keeping the Bash dispatcher and sequencing overlapping work avoids unnecessary complexity; the upstream settings proposal remains explicitly approval-gated.

Verification: inspected all six changed quest files and relevant publication transitions, audio/video probing, fullscreen/stats helpers, settings registries, dispatcher tables, and linked prerequisite plans at this commit. This does not validate a future implementation; no tests, browser checks, or builds were run.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: five new m2 quests from the 2026-10-27 refactor audit, with the maintainer's interview decisions recorded in the PR body and in each quest's Plan. CI passed, Codex reviewed 263775a with no findings, and quest check --base origin/main is clean. Landing on the maintainer's go-ahead.

Candidate to jump the queue: this diff is only quest files.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 28, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Re-land summary: the PR left the merge queue on failed_checks and had since conflicted with main. Merging main in made quest check fail: dispatch-modules.md required /quest/m0/ci/select-audit.md, but moq-dev/moq#6991 had already finished and deleted that quest. 1e1aac4 drops that Required entry and the plan line that waited on it, since sh/dispatch.sh still keeps the parallel scope/tools/compiles/lane/alone tables the quest targets. The PR body now says so. Codex reviewed 1e1aac4 with no findings, and quest check --base origin/main is clean. Landing on the earlier merge pick.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 9862b04 Oct 29, 2026
11 checks passed
@kixelated
kixelated deleted the quest-plan/refactor-audit branch October 29, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant