Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ edge, which embeds moq-relay; it moved there on 2026-09-28.
## Required

- [Nightly passes on main](/quest/m0/nightly/README.md) - the scheduled Nightly passes end to end, so red means a new break
- [Interop and Video pass on main](/quest/m0/interop-green/README.md) - the scheduled Interop and Video workflows pass, so red means a new break
- [Release shutdown backport](/quest/m0/ffi-shutdown-backport.md) - `release` publishes a non-breaking moq-ffi with an async `drain()` and qmux sessions on the QUIC stream limit
- [Backport IETF close codes](/quest/m0/backport-ietf-close-codes.md) - `@moq/net` on `release` closes moq-transport sessions with the right error for three hostile cases
- [Backport @moq/flate bounds](/quest/m0/backport-flate-budget.md) - `@moq/flate` on `release` stops inflating past its cap and stops pinning pako scratch
Expand Down
36 changes: 36 additions & 0 deletions quest/m0/interop-green/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Interop and Video pass on main

## Goal

The scheduled Interop and Video workflows pass on `main`, so a red run
means a new break. Interop has failed every scheduled run since
2026-10-22, and Video fails on a stale expectation.

## Plan

Decided 2026-10-27 (maintainer), from an external release-to-main audit
and a triage of Interop runs
[40517499786](https://github.com/moq-dev/moq/actions/runs/40517499786),
[40344007093](https://github.com/moq-dev/moq/actions/runs/40344007093), and
[40195571889](https://github.com/moq-dev/moq/actions/runs/40195571889):
one child per distinct cause, each landing on its own, as the
[Nightly epic](/quest/m0/nightly/README.md) does.

Not failures: the `FAIL pinned round`, `timeout round`, `empty round`, and
port-reservation lines are negative self-tests in
`interop/relay-log.test.sh` and `lib/harness.test.sh` that pass.
Already owned: the intermittent media-matrix timestamp-gap cells
(`cpp -> js-native-node`, `go -> c`, browser `rust -> js` timeouts) belong to
[test flakes](/quest/m0/test-flakes-2/README.md), with
[moq-dev/moq#6990](https://github.com/moq-dev/moq/pull/6990) open.

This README's own work, after the children: confirm a scheduled Interop
and Video run each pass.

Public API: none. Wire: none.

## Required

- [Draft-18 tail ends cleanly](/quest/m0/interop-green/tail-empty-group.md) - a Rust tail subscriber joining a JS publisher over moq-transport-18 gets every group and a clean end
- [Browser tests expect current behavior](/quest/m0/interop-green/stale-browser-tests.md) - the renderer and element version tests match the shipped validation and version list
- [Remeasure the planned wire break](/quest/m0/interop-green/wire-compat-remeasure.md) - the lite-07-wip planned break is measured against `@moq/net` 0.4.6
25 changes: 25 additions & 0 deletions quest/m0/interop-green/stale-browser-tests.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# [XS] Browser tests expect current behavior

## Goal

The Video workflow's renderer test and the Interop harness's element
version tests assert the behavior the elements ship.

## Plan

- `test/video/renderer.browser.ts` expects an invalid `url` and `volume`
attribute to reset to their defaults with no page errors. The elements now
keep the last valid value, report the invalid attribute as a page error,
and suspend media until it is fixed (`js/watch/MIGRATE.md`). Assert that
contract: the last valid value is kept, each invalid attribute reports
once, and media stays suspended until a valid value returns. It fails
every Video run on main.
- `test/interop/clients/js/publish-ui.browser.ts` (the "version lists keep
their defaults" and "version lists refuse unsupported" tests) uses
`moq-transport-14`, which
[moq-dev/moq#6753](https://github.com/moq-dev/moq/pull/6753) removed, so
the setter throws `unsupported version`. Use a supported draft where the
test means a valid version and keep an unsupported one only where it
tests the refusal.

Public API: none. Wire: none.
28 changes: 28 additions & 0 deletions quest/m0/interop-green/tail-empty-group.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# [M] Draft-18 tail ends cleanly

## Goal

In `just test interop --tail --versions ietf`, a Rust tail subscriber
joining a JS-native publisher (node and bun) over moq-transport-18 receives
every group with its frames and a clean end, as it does over draft 22.

## Plan

Interop run [40517499786](https://github.com/moq-dev/moq/actions/runs/40517499786)
(head [38bc872f](https://github.com/moq-dev/moq/commit/38bc872f1dec5ece74e07f43b508443d8a300378))
fails `tail js-native-node -> rust` and `tail js-native-bun -> rust` with
`Error: empty group` from `test/interop/clients/rust/tail.rs`; the publisher
is `test/interop/clients/js-native/tail.ts` under `run_tail_pair` in
`test/interop/interop.sh`. Draft 22 passes the same cell, and draft 18
passed at [8810d736](https://github.com/moq-dev/moq/commit/8810d736518185eb813dc8758f8f95f31d50cc9e),
so it is a deterministic regression between the two.

Reproduce on current main first:
[3079d472](https://github.com/moq-dev/moq/commit/3079d47269727b3f03d96f3b9cad4737c7696cd8)
changed how a group reported dropped is finalized and may already fix it. If
it still fails, bisect the range and fix at the source, whether that is the
JS IETF publisher (`js/net/src/ietf/publisher.ts`) or the Rust IETF
subscriber (`rs/moq-net/src/ietf/`); never relax the tail check. If it
passes, delete this quest with the passing run as evidence.

Public API: none expected. Wire: none expected.
17 changes: 17 additions & 0 deletions quest/m0/interop-green/wire-compat-remeasure.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# [XS] Remeasure the planned wire break

## Goal

`just test wire-compat` runs again: the lite-07-wip planned break in
`test/interop/compat/planned-breaks.json` is measured against the released
`@moq/net` 0.4.6 instead of 0.4.5.

## Plan

npm published `@moq/net` 0.4.6 on 2026-10-23, so `stale()` in
`test/interop/compat/resolve.ts` refuses every scheduled run since. Run
`just test wire-compat --remeasure`, confirm the lite-07-wip cells still
fail against the released builds and the stable lite-01 through lite-06
cells still pass, and update the entry's releases and reason with the date.

Public API: none. Wire: none.
7 changes: 7 additions & 0 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ GPU encode and source import quests are in m1 so
moq-video's GPU encode and import API changes, mainly encoders taking a GPU
surface and zero-copy texture import, land before the cut.

Added 2026-10-27 (maintainer, from an external release-to-main audit): the
bindings' silent `max_delay` default change and the upgrade notes that
contradict the code. Its other findings already had owners or contradicted
settled decisions (archives break in place; OBS video-only output stays
removed).

## Required

- [Resume checked against a model](/quest/m1/resume-model-test.md) - a randomized test checks every resumed reader against a one-track reference model in Rust and JS, and passes before the cut
Expand All @@ -131,6 +137,7 @@ surface and zero-copy texture import, land before the cut.
- [Moxygen minimal interop](/quest/m1/smoke-moxygen.md) - waiting on Moxygen to send a registered filter type, then the smoke lane stops hiding its failure
- [Moxygen pin bump](/quest/m1/moxygen-pin-bump.md) - waiting on moxygen#264, then the TRACK_STATUS patch is dropped
- [Broadcast lifecycle](/quest/m1/broadcast-lifecycle/README.md) - broadcasts are online or offline with no finished state in moq-net, finished-broadcast retention is a fixed moq-mux policy, and each linger timer has one meaning
- [Upgrade notes match the code](/quest/m1/upgrade-guide-facts.md) - the upgrade and CLI migration guides stop promising drafts 19-21, capped grants, and an ignored `MOQ_EPOCH`
- [A smaller, safer API than release](/quest/m1/api-audit/README.md) - every surface added since release has a consumer or is gone, overlapping operations are collapsed, names mirror across Rust, JS, and the bindings, and every break says how to migrate
- [moq-transport 18 and 22 only](/quest/m1/ietf-drop/README.md) - drafts 14-17 and 19-21 are deleted from Rust, JS, tests, interop lanes, and docs, removing the legacy control-stream adapter and its request limit
- [moq-quic's API improves on quinn's](/quest/m1/quic-api/README.md) - moq-quic and both QUIC drivers ship one mirrored API: `send::`/`recv::` namespaces, one error per direction, consuming terminal operations, plain configs, no quinn baggage
Expand Down
1 change: 1 addition & 0 deletions quest/m1/api-audit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ Rejected in planning:
## Required

- [Two broadcast resolutions](/quest/m1/api-audit/resolve.md) - Rust, JS, and the bindings resolve a broadcast with `request(path, epoch)` or `follow(path, epoch)`, and every racy two-step caller is gone
- [Bindings default to zero max delay](/quest/m1/api-audit/binding-max-delay.md) - a no-argument subscription skips superseded groups in every binding, as Rust, JS, and Python do, and no subscriber limit is asked for explicitly
- [Binding publications](/quest/m1/api-audit/binding-publication.md) - moq-ffi, the C ABI, and every wrapper hand out a publication handle that announces, replacing the private adapters
- [Demand is wanted, everywhere](/quest/m1/api-audit/wanted.md) - every `used`/`unused` pair becomes `wanted()` and `wanted_changed()`, and unused ones go
- [One meaning for Credential](/quest/m1/api-audit/dial-credential.md) - the internal dial type gets its own name in JS and moq-tokio, and the `Presented` alias goes
Expand Down
46 changes: 46 additions & 0 deletions quest/m1/api-audit/binding-max-delay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# [S] Bindings default to zero max delay

## Goal

A subscription built with no arguments skips superseded groups at once in
every language, as Rust, JS, Python, and the released bindings do. `null`
(Rust `None`) keeps meaning "no subscriber limit", distinct from zero, and a
reader asks for it explicitly.

## Plan

Decided 2026-10-27 (maintainer), from an external release-to-main audit
that found the regression in Dart; it reaches every binding that exposes
the generated record directly.

- Release generated `MoqSubscription(maxAgeUs: 0)`. Today
`MoqSubscription.max_delay` is `Option<Duration>` with no UniFFI default,
because UniFFI cannot spell a duration literal
(`rs/moq-ffi/src/consumer.rs`), so a bare constructor sends `None`. moq-net
reads `None` as a `Duration::MAX` budget
(`rs/moq-net/src/model/subscription.rs`), while its own
`Subscription::default()` is `Some(Duration::ZERO)`. An unchanged
`Subscription()` therefore compiles and silently trades latency for
delivery of every retained superseded group.
- Keep both meanings: zero is the default, `None` is no subscriber limit.
Rejected: making `None` the default everywhere, since it changes Rust and
JS live readers too and adds latency after congestion.
- Python already wraps the record with `max_delay = timedelta(0)`
(`py/moq-rs/moq/_records.py`); follow it. Dart
(`dart/moq/lib/src/aliases.dart`), Swift (`swift/Sources/Moq/Aliases.swift`),
and Kotlin (`kt/moq/src/jvmAndAndroidMain/kotlin/dev/moq/Aliases.kt`)
alias the generated record, so each gets a hand-written `Subscription`
whose default is zero. Go's `Subscription` (`go/wrapper/records.go`) is a
struct whose zero value leaves `MaxDelay` nil; pick a Go shape whose zero
value means zero delay and name the no-limit spelling, and raise that
shape in the PR as the API decision. Check C++ aggregate initialization
in `cpp/moq` and the `moq-c` subscription the same way.
- Audit the other binding records whose `max_delay` mirrors a moq-net
default (fetch options, decoder outputs) against release and fix any that
drifted the same way.
- Test that each wrapper's no-argument subscription reaches moq-net as
`Some(0)`.

Public API: breaking for Dart, Swift, Kotlin, and Go, whose `Subscription`
changes type or default; the Impact bullet says a reader that wants no
subscriber limit now passes it explicitly. Wire: none.
6 changes: 6 additions & 0 deletions quest/m1/time-addressing/consumers.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ relay and CLI `fetch --group`, and player continuity checks in the Rust and
JS container consumers and `js/watch`. Update the hang draft and the docs
each one makes stale; rename CLI flags per the repo's CLI rule.

Added 2026-10-27 (maintainer, from an external release-to-main audit): an
HLS exporter today requests the record tracks, but on-demand capture starts
from media-track demand, so an HLS-only viewer never starts it. Once the
export reads media tracks directly, prove that an HLS-only viewer of an
on-demand publisher starts capture and gets a playlist.

Public API: breaking where a consumer exposes group numbers (CLI
`--group`, archive keys), and `moq_mux::hls`, `hang::hls`, and
`catalog::Config::with_hls` are deleted. Wire: hang drops empty duration
Expand Down
30 changes: 30 additions & 0 deletions quest/m1/upgrade-guide-facts.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# [XS] Upgrade notes match the code

## Goal

The upgrade guide and the CLI migration guide stop promising behavior the
code refuses: moq-transport drafts 18 and 22 only, no capped grants, and a
`MOQ_EPOCH` that stops startup.

## Plan

Decided 2026-10-27 (maintainer), from an external release-to-main audit.
Each is a fact an earlier change made stale.

- `doc/setup/upgrade.md` says Rust and JavaScript speak drafts "18 through
22"; `rs/moq-net/src/ietf/version.rs` has only `Draft18` and `Draft22`.
- `doc/setup/upgrade.md`'s "Capped grants need upgraded verifiers" bullet
describes a `rate` cap that moq-auth now refuses as an object role
(`rs/moq-auth/MIGRATE.md`). Replace it with the true rule: uncapped tokens
keep their format, and an object role is refused.
- `rs/moq-cli/MIGRATE.md` says `MOQ_EPOCH` is ignored, but `check_env`
(`rs/moq-tokio/src/cli/env.rs`) refuses every undeclared `MOQ_*`
variable. Keep the refusal (fail loud) and say startup stops until the
variable is removed.
- Grep the other `MIGRATE.md` files and `doc/` for removed `MOQ_*`
variables described as ignored and fix them the same way.

Collapsing intermediate entries stays with the
[migration audit](/quest/m2/release/migrate-audit.md).

Public API: none. Wire: none.
5 changes: 5 additions & 0 deletions quest/m2/release/migrate-audit.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ m1 quest on 2026-10-22.
API audit). Collapse entries a later change reversed or reshaped (an API
removed then reintroduced, a default changed twice) into the net change,
and drop the intermediate history.
- Read the API-diff report's auto-trait changes too, not only renamed or
removed items (added 2026-10-27, from an external release-to-main audit
that found lost `Sync` on JSON consumers, fMP4/HLS importers, video decode
consumers, and relay state). Restore an accidental loss at its source;
otherwise the migration note says how to share the type instead.
- Compile-check the code in every `MIGRATE.md` section the cut ships against
the candidate. Nothing else builds it.
- Required by the cut, after m1's breaking work has landed.
Expand Down
Loading