Skip to content

docs(quest): finish the flate release backport - #6955

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest/m0/backport-flate-budget
Oct 30, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest/m0/backport-flate-budget

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The m0 quest tracking the @moq/flate release backport stays open after its condition has cleared.

Approach

The condition in the quest's Goal holds, so this PR deletes the quest and its link from the m0 README.

  • moq-dev/moq#6961 merged into release (stops inflation at the per-frame cap, returns owned tight buffers).
  • moq-dev/moq#7019 bumped @moq/flate to 0.1.4 on release.
  • Release JS run 40640290623 succeeded on release at the bump commit.
  • npm view @moq/flate version reports 0.1.4, and the published tarball's index.js throws inside onData past the cap, rejects later frames after an overflow, and copies output into a tight buffer in a finally.

Impact

  • Public API: none.
  • Wire: none.

Validation

  • quest check passes (rerun after merging main).
  • Rechecked on 2026-10-29: npm view @moq/flate version reports 0.1.4; moq-dev/moq#6961 and moq-dev/moq#7019 are merged into release.

Notes

  • Merged main to clear the conflict in quest/m0/README.md; it resolved without manual edits. Merged main again on 2026-10-30 after the old GitHub merge queue ejected the PR as merge_conflict; that merge was also conflict-free.
  • Taken over from a stale quest:iterate session with the maintainer's approval. That session had finished the work and removed ## Decisions needed, but never marked the PR ready or released it.

Review

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title Backport the @moq/flate inflate bounds to release docs(quest): track the flate release backport Oct 28, 2026
@kixelated kixelated changed the title docs(quest): track the flate release backport docs(quest): finish the flate release backport Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 29, 2026 15:26
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f57d648a-8e9e-4362-95bb-0499255bffe9
Commits

Reviewing files that changed from the base of the PR and between 80cafb3 and be2b817.

Files selected for processing: 2
  • quest/m0/README.md
  • quest/m0/backport-flate-budget.md
Files with no reviewable changes: 2
  • quest/m0/README.md
  • quest/m0/backport-flate-budget.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The required-priorities list no longer includes the @moq/flate bounds backport. The document describing the proposed backport to the older release implementation was deleted.

Priority: Low

Merge Risk: Minimal · up to be2b8

No actionable issue with the documentation removal is identified; it is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the documentation change and the completion of the flate release backport tracked by the deleted quest.
Description check Passed The description directly explains why the quest and README link are deleted, and it matches the reported changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T14:43:32.646315Z be2b817 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed 360c099e487811c2b7c9637dd0b1a10b9bb0c48c.

No actionable bugs found in this documentation-only cleanup. Removing the completed quest and its index entry is appropriate: #6961 merged the per-frame inflation stop and tight owned-buffer changes into release, #7019 bumped the package to 0.1.4, and the linked Release JS run completed successfully at that bump commit. No runtime or wire behavior changes here.

Verification: static GitHub review of the deletion, referenced merged changes, package version, and workflow result. I did not run tests or independently inspect npm's current metadata or published tarball.

(Written by OpenAI)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: the body no longer carries a ## Decisions needed section, and nothing is left open. Both backports are on release (moq-dev/moq#6961, moq-dev/moq#7019, both merged), and npm view @moq/flate version reports 0.1.4. CI passes (12/12). The Codex and OpenAI reviews of 360c099e48 found nothing. quest check --base origin/main passes on the head. Landing it through the merge queue.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 30, 2026
@kixelated
kixelated enabled auto-merge (squash) October 30, 2026 14:42
* chore(quest): claim quest/m0/backport-flate-budget.md

Quest-Claim: 63fc4c5676a40eb1

* docs(quest): track the flate release backport PR

* docs(quest): finish the flate release backport

#6961 merged into release and @moq/flate 0.1.4 is on npm
with the bounded inflation and owned output.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GPT-6 <noreply@openai.com>
@moq-bot
moq-bot Bot force-pushed the quest/m0/backport-flate-budget branch from be2b817 to 67ac55e Compare October 30, 2026 17:31
@moq-bot
moq-bot Bot merged commit 67ac55e into main Oct 30, 2026
7 checks passed
@moq-bot
moq-bot Bot deleted the quest/m0/backport-flate-budget branch October 30, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant