Repository navigation
docs(quest): finish the flate release backport - #6955
Conversation
|
No actionable comments were generated in the recent review.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 360c099e487811c2b7c9637dd0b1a10b9bb0c48c.
No actionable bugs found in this documentation-only cleanup. Removing the completed quest and its index entry is appropriate: #6961 merged the per-frame inflation stop and tight owned-buffer changes into release, #7019 bumped the package to 0.1.4, and the linked Release JS run completed successfully at that bump commit. No runtime or wire behavior changes here.
Verification: static GitHub review of the deletion, referenced merged changes, package version, and workflow result. I did not run tests or independently inspect npm's current metadata or published tarball.
(Written by OpenAI)
|
Merge summary: the body no longer carries a (Written by Claude Opus 5.5) |
* chore(quest): claim quest/m0/backport-flate-budget.md Quest-Claim: 63fc4c5676a40eb1 * docs(quest): track the flate release backport PR * docs(quest): finish the flate release backport #6961 merged into release and @moq/flate 0.1.4 is on npm with the bounded inflation and owned output. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: GPT-6 <noreply@openai.com>
be2b817 to
67ac55e
Compare
Problem
The m0 quest tracking the @moq/flate release backport stays open after its condition has cleared.
Approach
The condition in the quest's Goal holds, so this PR deletes the quest and its link from the m0 README.
release(stops inflation at the per-frame cap, returns owned tight buffers).@moq/flateto 0.1.4 onrelease.releaseat the bump commit.npm view @moq/flate versionreports 0.1.4, and the published tarball'sindex.jsthrows insideonDatapast the cap, rejects later frames after an overflow, and copies output into a tight buffer in afinally.Impact
Validation
quest checkpasses (rerun after mergingmain).npm view @moq/flate versionreports 0.1.4; moq-dev/moq#6961 and moq-dev/moq#7019 are merged intorelease.Notes
mainto clear the conflict inquest/m0/README.md; it resolved without manual edits. Mergedmainagain on 2026-10-30 after the old GitHub merge queue ejected the PR asmerge_conflict; that merge was also conflict-free.quest:iteratesession with the maintainer's approval. That session had finished the work and removed## Decisions needed, but never marked the PR ready or released it.Review
mainonly deletesquest/m0/backport-flate-budget.mdand its one link inquest/m0/README.md.quest check --base origin/mainpasses, and the quest's condition still holds on 2026-10-30 (@moq/flate0.1.4 on npm; fix(flate): stop oversized release frames during inflation #6961 and chore(js): bump @moq/flate and @moq/net on release #7019 merged intorelease).(Written by Claude Opus 5.5)