Skip to content

quest: keep crane for Nix packages; drop crate2nix - #6886

Merged
kixelated merged 1 commit into
mainfrom
quest/drop-crate2nix
Oct 27, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/drop-crate2nix

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Deletes quest/m0/ci/crate2nix.md (merged in #6880) and records why in the CI epic.

kixel-ai/rust2#63's first crate2nix numbers had bugs: the default features were dropped and the builds didn't use moq's release profile. Corrected, in billions of instructions:

scenario crane crane+mbx crate2nix cargo+mbx
clean 3,681 3,377 4,672 3,378
second package 5,926 3,945 6,999 3,924
moq-net edit 1,365 1,351 1,509 1,276
lockfile bump 3,681 1,123 1,255 1,113
total 14,756 9,894 14,538 9,692

crate2nix now totals about the same as crane. It wins only the lockfile bump and costs 11-27% more on everything else.

Decision paper trail:

With corrected numbers, which direction should moq's CI build take?

  • ✅ cargo+mbx (Recommended): cheapest total and works without Nix. Nix stays for packaging only.
  • crane+mbx: keep crane, add mbx.
  • Keep crate2nix: only wins lockfile bumps.

PR CI already builds with cargo and mbx, so nothing changes there. The Nix packages stay on crane.

Dropped with the quest:

  • the committed Cargo.nix and its regeneration bot;
  • moving moq-relay's frame-pointer flag into .cargo/config.toml. Nix builds can't share cargo's cache, so unifying their flags saves nothing.

hakari.md no longer links the deleted quest.

Public API: none.

(written by Opus 5.5)

🤖 Generated with Claude Code

https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 21e024b6-10a9-427a-887a-b9de17c8cd89
Commits

Reviewing files that changed from the base of the PR and between 020693b and 19f83fd.

Files selected for processing: 3
  • quest/m0/ci/README.md
  • quest/m0/ci/crate2nix.md
  • quest/m0/ci/hakari.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T19:49:01.836839Z 19f83fd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed SHA: 19f83fdb6e285cccc9f94103f761601d3996120a.

No actionable findings. The revised totals and 11–27% overhead match the corrected benchmark, and both links to the deleted quest are removed. The existing Cargo/mbx CI and crane packaging paths already implement the stated split.

Direction: retaining those paths is simpler than adding a generated Cargo.nix, regeneration bot, and another build configuration for roughly equal aggregate instruction cost. Keeping the independent feature-unification/cache-verification work is appropriate.

No prior findings on this PR to classify. Verification: GitHub-only static review of all three changed files, benchmark results/review history, and the relevant CI/cache action and Nix overlay. I did not run checks or independently reproduce the benchmark.

(Written by OpenAI)

@kixelated
kixelated added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 96fd152 Oct 27, 2026
10 checks passed
@kixelated
kixelated deleted the quest/drop-crate2nix branch October 27, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant