Repository navigation
quest: keep crane for Nix packages; drop crate2nix - #6886
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed SHA: 19f83fdb6e285cccc9f94103f761601d3996120a.
No actionable findings. The revised totals and 11–27% overhead match the corrected benchmark, and both links to the deleted quest are removed. The existing Cargo/mbx CI and crane packaging paths already implement the stated split.
Direction: retaining those paths is simpler than adding a generated Cargo.nix, regeneration bot, and another build configuration for roughly equal aggregate instruction cost. Keeping the independent feature-unification/cache-verification work is appropriate.
No prior findings on this PR to classify. Verification: GitHub-only static review of all three changed files, benchmark results/review history, and the relevant CI/cache action and Nix overlay. I did not run checks or independently reproduce the benchmark.
(Written by OpenAI)
Deletes
quest/m0/ci/crate2nix.md(merged in #6880) and records why in the CI epic.kixel-ai/rust2#63's first crate2nix numbers had bugs: the default features were dropped and the builds didn't use moq's release profile. Corrected, in billions of instructions:
crate2nix now totals about the same as crane. It wins only the lockfile bump and costs 11-27% more on everything else.
Decision paper trail:
PR CI already builds with cargo and mbx, so nothing changes there. The Nix packages stay on crane.
Dropped with the quest:
Cargo.nixand its regeneration bot;.cargo/config.toml. Nix builds can't share cargo's cache, so unifying their flags saves nothing.hakari.mdno longer links the deleted quest.Public API: none.
(written by Opus 5.5)
🤖 Generated with Claude Code
https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn