Skip to content

chore(quest): retire Python setup work after concurrent lanes - #6667

Merged
kixelated merged 5 commits into
mainfrom
quest/m0/ci/python-setup
Oct 25, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m0/ci/python-setup

Conversation

@kixelated

@kixelated kixelated commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

moq-dev/moq#6617 moved Python checks and tests next to each other in the same lane. The Python preparation quest now says to delete it if the second preparation no longer recompiles.

Approach

Remove the obsolete quest and its epic link. An adjacent warm-cache baseline in this checkout performed no recompilation during its second preparation: the native target and UniFFI generator checks finished in 0.39 s and 0.30 s. Keep the existing Python recipes and dispatcher.

Impact

  • No public API, wire, package, or runtime behavior changes.

Alternatives

Sharing preparation through a Just dependency reduced preparation invocations, but became unnecessary once the lane change removed the observed expensive recompilation. Drop that implementation and its tests from this PR.

Validation

  • The adjacent baseline passed Python lint, types, documentation samples, Sphinx, and all 107 tests.
  • Final quest-only selected just ci passes.
  • Final diff contains only the quest and epic-link removal.

Follow-ups

None.

(Written by GPT-6)

kixelated and others added 3 commits October 24, 2026 11:01
Verify invocation-local preparation, standalone recipes, and preparation failure propagation. Python checks and all 107 tests pass; the 20 tooling tests, shell and recipe formatting, and quest validation pass. Full selected CI is still running.

Co-Authored-By: Codex <noreply@openai.com>
Share a private Just dependency between checks and tests. Standalone recipes still prepare the current checkout every time. Regression tests cover both recipe orders and preparation failure.

Co-Authored-By: Codex <noreply@openai.com>
@kixelated kixelated changed the title Share Python check and test preparation fix(ci): share Python preparation across checks and tests Oct 24, 2026
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 18:14
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 28a40a17-a1b9-48dc-be43-64aa9e34dbd6
Commits

Reviewing files that changed from the base of the PR and between bab4d8a and c6d72e7.

Files selected for processing: 3
  • quest/m0/ci/README.md
  • quest/m0/ci/ffi-lane.md
  • quest/m0/ci/python-setup.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T04:08:35.908349Z c6d72e7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Merge main and follow the revised quest: adjacent Python preparations no longer rebuild either native target. Keep the existing recipes and dispatcher instead of adding shared preparation machinery.

Co-Authored-By: Codex <noreply@openai.com>
@kixelated kixelated changed the title fix(ci): share Python preparation across checks and tests chore(quest): retire Python setup work after concurrent lanes Oct 24, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main into the branch (no rebase) to clear the conflict in quest/m0/ci/README.md. main had removed the OBS-parallel entry and added Check the bindings in separate lanes. The resolved list keeps ffi-lane and leaves out python-setup.

I also dropped the now-dangling python-setup.md Related link from quest/m0/ci/ffi-lane.md. The retirement still stands under ffi-lane's plan: just py check and just py test both build with testing,openh264 and stay together in py's own lane, so the second preparation still finds the build fresh.

quest check --base origin/main passes (558 documents).

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 3fd7f4b Oct 25, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/ci/python-setup branch October 25, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant