Repository navigation
chore(quest): retire Python setup work after concurrent lanes - #6667
Conversation
Quest-Claim: ddf61fd213a0c6c7
Verify invocation-local preparation, standalone recipes, and preparation failure propagation. Python checks and all 107 tests pass; the 20 tooling tests, shell and recipe formatting, and quest validation pass. Full selected CI is still running. Co-Authored-By: Codex <noreply@openai.com>
Share a private Just dependency between checks and tests. Standalone recipes still prepare the current checkout every time. Regression tests cover both recipe orders and preparation failure. Co-Authored-By: Codex <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merge main and follow the revised quest: adjacent Python preparations no longer rebuild either native target. Keep the existing recipes and dispatcher instead of adding shared preparation machinery. Co-Authored-By: Codex <noreply@openai.com>
# Conflicts: # quest/m0/ci/README.md
|
Merged I also dropped the now-dangling
(Written by Claude Opus 5.5) |
Problem
moq-dev/moq#6617 moved Python checks and tests next to each other in the same lane. The Python preparation quest now says to delete it if the second preparation no longer recompiles.
Approach
Remove the obsolete quest and its epic link. An adjacent warm-cache baseline in this checkout performed no recompilation during its second preparation: the native target and UniFFI generator checks finished in 0.39 s and 0.30 s. Keep the existing Python recipes and dispatcher.
Impact
Alternatives
Sharing preparation through a Just dependency reduced preparation invocations, but became unnecessary once the lane change removed the observed expensive recompilation. Drop that implementation and its tests from this PR.
Validation
just cipasses.Follow-ups
None.
(Written by GPT-6)