Skip to content

quest: finish the HLS admission backport - #6638

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/hls-admission-backport
Oct 24, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/hls-admission-backport

Conversation

@kixelated

@kixelated kixelated commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The HLS import origin admission from #6374 is only on main; release, which moq.dev runs, still follows a hostile playlist to other origins.

Approach

The backport is #6640 into release, which keeps import::Config::client so it ships as a non-breaking moq-hls patch. This PR deletes quest/m0/hls-admission-backport.md and its m0 entry with quest rm.

Merge #6640 first; release-plz on release then publishes the moq-hls patch.

Impact

Quest tracking only; no public API or wire changes.

Validation

quest check and just check pass.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 24, 2026 08:06
@kixelated kixelated changed the title Backport HLS import admission to release quest: finish the HLS admission backport Oct 24, 2026
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 15:08
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 71a62bc7-9b03-4f87-8337-d966d48519c3
Commits

Reviewing files that changed from the base of the PR and between 147c1e1 and d992c3f.

Files selected for processing: 2
  • quest/m0/README.md
  • quest/m0/hls-admission-backport.md
Files with no reviewable changes: 2
  • quest/m0/hls-admission-backport.md
  • quest/m0/README.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The pull request removes the HLS admission backport item from the README and deletes its plan document. The deleted plan described proposed origin-admission and redirect-hop checks for the client built by moq-hls.

Priority: Low

Merge Risk: Minimal · up to d992c

This tracking cleanup is ready to merge based on the supplied evidence.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies completion of the HLS admission backport, which matches the deleted quest plan and its m0 entry.
Description check Passed The description explains why the HLS admission backport tracking was removed, identifies the related backport, and states the validation results.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T16:56:23.177829Z d992c3f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: the backport #6640 has merged into release, so this PR's deletion of quest/m0/hls-admission-backport.md is now accurate. The base-relative quest check --base origin/main passes on e453d95, CI is green, and Codex reacted with a thumbs-up. Landing through the merge queue.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 24, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit bd8fe94 Oct 24, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/hls-admission-backport branch October 24, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant