Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion doc/bin/hls.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ ended, such as a VOD recording, is refused with an error rather than imported.
An `EXT-X-DISCONTINUITY` keeps the source's timestamps. Timestamp resets are not
supported: if a rendition's timestamps go backwards under the same `EXT-X-MAP`,
such as an encoder restart, the import fails with an error. Import the restarted
source as a new broadcast.
source as a new broadcast. Import fetches only from the playlist's origin
(scheme, host, and port): a reference or redirect to another origin, such as a
separate CDN host, fails the import.

## How export works

Expand Down
6 changes: 1 addition & 5 deletions quest/m0/hls-admission-backport.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

`release`, which moq.dev runs, refuses the same hostile HLS playlists `main`
does: the origin-admission and redirect-hop checks from
[HLS admission](/quest/m1/release-audit/hls-admission.md) ship in a
[moq-dev/moq#6374](https://github.com/moq-dev/moq/pull/6374) ship in a
non-breaking `moq-hls` patch release.

## Plan
Expand All @@ -20,7 +20,3 @@ on `main`, following the shape of
`release`, no breaking change, a patch release.

Public API: none on `release`. Wire: none.

## Required

- [HLS admission](/quest/m1/release-audit/hls-admission.md) - the checks land and are validated on `main` first
8 changes: 3 additions & 5 deletions quest/m1/release-audit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ indexes, JS IETF timestamp changes, JS datagram range violations, and OBS
reordered-frame timestamps and missing EOF output. Each owning quest records
the reproduction's limits. JS reader and publisher datagram paths now enforce
subscription bounds; the OBS quest retains ownership of its findings.
Go reservation disposal remains an investigation, and
the security-sensitive HLS admission item is deliberately a public pointer.
Go reservation disposal remains an investigation.
No platform-wide binding parity, full OBS runtime, fuzzing campaign, or
network-impairment performance result is implied by these checks.

Expand All @@ -88,11 +87,10 @@ work, because obs-moq ships on its own schedule.

## Required

The entries comprise reproduced or source-confirmed findings,
contract/lifetime investigations, and one security-review pointer. Each
The entries comprise reproduced or source-confirmed findings
and contract/lifetime investigations. Each
child records whether its behavior is new on main or inherited from release.

- [Review HLS admission](/quest/m1/release-audit/hls-admission.md) - resolve the security-sensitive resource-boundary review before the cut
- [Decode order](/quest/m1/ts-reliability/decode-order.md) - the exporters' decode clock holds at most the declared reorder depth, so flat timestamps cannot bypass MKV/TS backpressure or cause quadratic draining
- [Release AUTH wake listeners](/quest/m1/release-audit/auth-listeners.md) - session churn does not retain one terminal promise reaction per change
- [Finish bitrate recovery](/quest/m1/release-audit/rate-recovery.md) - a quiet bandwidth grant no longer strands moq-video, moq-ffi, and moq-c encoders partway up the ramp
Expand Down
33 changes: 0 additions & 33 deletions quest/m1/release-audit/hls-admission.md

This file was deleted.

4 changes: 0 additions & 4 deletions quest/m2/hls-variant-area.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ Today `select_variants` in `rs/moq-hls/src/import.rs` computes `width * height`
From the 2026-10-22 security audit. Compute the area as an exact widened product (for example `u128` from the two `u64` dimensions), so every resolution ranks by its true area. Saturating would collapse large areas into ties that bandwidth and map order then break arbitrarily. A test with an enormous `RESOLUTION` covers both the panic and the ordering.

Public API: none. Wire: none.

## Related

- [HLS admission](/quest/m1/release-audit/hls-admission.md) - the other HLS import hardening from the audit
4 changes: 4 additions & 0 deletions rs/moq-hls/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ pub enum Error {
#[error("requested range is unavailable: {0}")]
RangeUnavailable(String),

/// An import resource or redirect hop left the playlist's origin, or the playlist uses an unsupported scheme.
#[error("resource is outside the playlist's origin")]
ResourceRefused,

/// A `file://` URL could not be turned back into a filesystem path.
#[error("invalid file URL")]
InvalidFileUrl,
Expand Down
Loading
Loading