Repository navigation
quest: scope benchmark-first performance audit findings - #6318
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
changed the title
kixelated
changed the title
This was referenced Oct 22, 2026
kixelated
added a commit
that referenced
this pull request
Oct 22, 2026
The performance survey (#6318) landed the same SendBuffer finding with a fuller plan, so drop the audit's duplicate and move that quest to m1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A source audit of main
1d43c096e044found performance risks that current benchmark shapes do not isolate. These are hypotheses, not claimed speedups or newly measured production regressions.Approach
Add 15 independently landable m2 quests under
quest/m2/performance-survey/, ranked by expected impact. Cover fragmented QUIC sends, task capacity after bursts, Rust/JS bandwidth allocation, cached JS group joins, PCM batching, fragmented MKV parsing, QUIC scheduling churn, HLS serving, buffered browser groups, datagrams, JWT verification, announcement snapshots, selective session operations, browser media copies and GStreamer buffer ownership.Every quest requires a production-path baseline, independent scaling sweeps, paired before/after evidence, equivalent-work correctness checks and nightly coverage. CPU, allocations, copies, retained memory and latency are measured where relevant. A measured no-win is a valid outcome. Browser findings require browser measurements; network performance uses finite-queue bufferbloat.
The real JS allocator operation-count probe found exactly 2N² priority reads for all grants in one tier: 512 / 8,192 / 131,072 for 16 / 64 / 256 reservations, excluding sorting. With distinct tiers, 16 to 64 reservations increased reads from 6,952 to 438,944. The reproducible command is in the bandwidth quest. This proves repeated work, not browser latency.
Impact
Alternatives
Reuse existing owners for release regressions, channel contention, FFI costs, GPU pools, routing wakes and worker isolation. Extract six existing audit coverage items into concrete quests and link them back; keep the recurring audit active for nightly attribution and remaining coverage. Do not optimize the archive reader being replaced.
The requested scope already authorizes this audit and benchmark-required planning; no implementation contract or API choice is settled here.
Validation
just cipasses for the final diff.quest check --base origin/main: 460 documents pass.git diff origin/main --checkpasses; all new repository links resolve.moq-archive/producernightly selection. moq-dev/moq#6266 already owns its fix; it is not duplicated.Follow-ups
The 15 new quests are the requested follow-ups. The epic records the audit revision, evidence limits, benchmark methodology and overlap with open PRs, including moq-dev/moq#6311.
(Written by GPT-6)