Skip to content

fix(net): align whole-group IETF FETCH end locations - #6295

Merged
kixelated merged 5 commits into
mainfrom
quest/m1/ietf-fetch-end-location
Oct 23, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m1/ietf-fetch-end-location

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

On moq-transport drafts 14-19 the publisher widens a whole-group FETCH end {g, 0} to {g+1, 0}, while the subscriber rejects a canonical {g, 0} answer. The widening also overflows at the maximum Group ID, including draft 20+ Absolute filters, returning INVALID_RANGE for a valid but unsupported range.

Closes #6199.

Approach

Keep the standalone request's whole-group form, compare groups without widening or subtraction, and echo {g, 0} for a covered whole group. The subscriber accepts both the canonical {g, 0} and the legacy {g+1, 0} answer, keeping the final sequence and object bounds. Draft 20+ stays inclusive.

Tests reproduce all three failures before the fix and cover drafts 14-22: canonical and legacy answers with and without End Of Track, nonzero frame starts, bounded ranges, cancellation, and the wire's maximum Group ID. The moq-net MIGRATE note and doc/concept/standard.md describe the drafts 14-19 meaning.

Retires quest/m1/ietf-fetch-end-location.md, which unblocks quest/m1/js-fetch.md.

Decision

The maintainer settled this on behavior (recorded in the merged quest): all three sides land together, with no staged rollout.

  • Pairings between released and current moq-net builds over IETF are out of scope; the MIGRATE note says to upgrade readers or use draft 20+.
  • moxygen's moqtest validator expects {g+1, 0} only because its toExclusiveEnd helper widens the request before comparing; its parser and fetch handle keep {g, 0}, and no data path fails. Behavior wins over that validator.

Impact

  • Public Rust/JS API: none.
  • Wire: drafts 14-19 whole-group FETCH_OK now names {g, 0} rather than {g+1, 0}; receivers still accept the old form. End Of Track sets the final sequence to the group after the fetched one. Draft 20+ encoding is unchanged.
  • IETF drafts: none. This repo's drafts/ describe moq-lite and its extensions; draft-lcurley-moq-ietf covers the moq-lite-07 relay hop, whose wire this does not touch, so the earlier note added there was dropped. The JS FETCH decoder (JS refuses every FETCH) is unchanged too.
  • Consumer: a spec-following peer answering our whole-group FETCH is served, and our answer no longer claims the next group is absent.

Validation

  • Pre-fix reproductions fail as expected: the canonical subscriber answer returns NotFound, the publisher sends {g+1, 0}, and a maximum-group multi-range returns INVALID_RANGE.
  • After merging main: moq-net tests pass (3029, 11 skipped), and just check passes JS, Rust clippy/lint, quest and drill; its flake module stops at the Nix runner-image build because this host denies unshare writing /proc/self/uid_map, unrelated to this change. quest check --base origin/main passes.
  • just test interop --all: 127 PASS, 0 FAIL across Rust, Python, Go, C++, JS (browser, node, bun), C and GStreamer publishers and subscribers, auth refusals, CLI FETCH, finite tails, compression and drop cases.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title FETCH_OK End Object 0 is the whole group fix(net): align whole-group IETF FETCH end locations Oct 22, 2026
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Checkpointed the complete three-sided FETCH candidate: canonical whole-group request/answer handling, dual-accepting reader, and overflow-free maximum-group range refusal. Required cross-language interop passes; all selected JS tests, drafts and lint checks pass. Default Rust tests pass 7,981/7,982, with only the known base CLI readiness failure handled in #6290; 511 capture/playback and 219 CLI playback feature tests pass. just ci hits the known host runner-image user-namespace restriction after its JS/draft/Rust/quest/drill stages; the remaining checks passed directly.

Public Rust/JS API is unchanged. Drafts 14-19 whole-group FETCH_OK changes from {g+1,0} to {g,0}; draft 20+ remains inclusive. MIGRATE documents old-reader pairing risk. No merge, rollout choice, peer detection, or compatibility shim was applied.

Keep draft for Decisions needed: staged reader-first rollout (recommended pending explicit compatibility approval) versus the quest's all-at-once exception. The body records a concrete pinned Moxygen trace: request End bytes 02 00, candidate reply 02 00, parser retains {2,0}, but moqtest's separate expectation helper requires {3,0} and marks a semantic failure. Its published seven-case interop smoke has no FETCH case; six cases pass per transport and announce-subscribe fails at the existing upstream prerequisite. Neither that smoke nor the in-tree matrix settles this validator choice.

(Written by GPT-6)

kixelated and others added 3 commits October 22, 2026 14:37
…nd-location

# Conflicts:
#	doc/concept/standard.md
#	rs/moq-net/MIGRATE.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The moq-ietf draft describes the moq-lite-07 relay extension, whose wire
this change does not touch, and the JS FETCH decoder is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 21:47
@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

(Written by Claude Opus 5.5)

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8587ede3-60e7-4950-944f-304ab35ad9f0
📥 Commits

Reviewing files that changed from the base of the PR and between 8540a03 and 19d4a36.

📒 Files selected for processing: 8
  • doc/concept/standard.md
  • quest/m1/README.md
  • quest/m1/ietf-fetch-end-location.md
  • quest/m1/js-fetch.md
  • rs/moq-net/MIGRATE.md
  • rs/moq-net/src/ietf/fetch.rs
  • rs/moq-net/src/ietf/publisher.rs
  • rs/moq-net/src/ietf/subscriber.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T21:49:56.201586Z 19d4a36 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19d4a36a5b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rs/moq-net/src/ietf/publisher.rs Resolved
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit c31d7a7 Oct 23, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m1/ietf-fetch-end-location branch October 23, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moq-net: draft-14 to 19 FETCH_OK End Location Object 0 means the whole group

1 participant