Skip to content

chore(quest): retire completed TRACK_STATUS reporting - #6260

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/track-status-race
Oct 22, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/track-status-race

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The TRACK_STATUS reporting quest remains ready even though its known upstream report was already filed. Its source race was fixed by moq-dev/moq#5991.

Approach

Verify the reporting goal is fulfilled, then use quest rm to delete the quest and its milestone link:

  • openmoq/moqx#842 reports the exact draft-18 TRACK_STATUS refusal with REQUEST_ERROR 0xFFFFFFFF, including the request context and reference to the moq-dev fix. It closed after upstream confirmed unknown codes are treated as INTERNAL_ERROR.
  • openmoq/moqx#843 remains open for emitting defined error codes. The quest requires an upstream report, not the upstream fix.
  • The quest, original moq-dev/moq#5954, landed fix, and current quest/issue searches name no other outstanding refusing relay needing a report. The historical own-relay moq-dev/moq#3492 is already closed.
  • No open PR claims this exact quest. No external GitHub post was made.

Impact

  • Public API: none.
  • Wire: none.
  • Consumer: quest scheduling stops presenting already-completed reporting work.

Alternatives

Keeping the quest until the upstream fix lands changes its explicit completion condition. Another report would duplicate existing upstream evidence.

Validation

  • nix develop --command just ci: passed.
  • quest check --base origin/main: passed, 461 documents.
  • rg track-status-race quest: no remaining references.
  • Diff whitespace checks: passed.

Follow-ups

None required for this cleanup. The upstream emission issue remains tracked by its existing report. No m2 work was started.

(Written by GPT-6)

kixelated and others added 2 commits October 21, 2026 22:15
The only outstanding relay report was filed as openmoq/moqx#842, with undefined error emission tracked by #843.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated kixelated changed the title Report relays that refuse TRACK_STATUS chore(quest): retire completed TRACK_STATUS reporting Oct 22, 2026
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 05:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T05:18:59.187860Z 719da7f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3806ab29-5f36-4fbd-818f-059a5e755b51
📥 Commits

Reviewing files that changed from the base of the PR and between e0cde15 and 719da7f.

📒 Files selected for processing: 2
  • quest/m1/README.md
  • quest/m1/track-status-race.md
💤 Files with no reviewable changes: 2
  • quest/m1/README.md
  • quest/m1/track-status-race.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The changes remove the quest document about reporting relays that refuse or return an undefined code for TRACK_STATUS. They also remove its entry from the quest index. The deleted document described the #5991 behavior, remaining failure cases, and the process for drafting and approving reports.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 719da

No actionable merge risk is identified for the quest removal; it is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely states that the completed TRACK_STATUS reporting quest is being retired.
Description check Passed The description directly explains why the TRACK_STATUS reporting quest is complete, what files are removed, and how the change was validated.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Completed factual cleanup at 719da7fe02: the reporting quest and its last milestone link are removed. Existing upstream reports satisfy its stated goal; no new external post or protocol change was made.

just ci, quest validation and whitespace checks passed. Codex reacted with a thumbs up on this head, and CodeRabbit reported no actionable findings. GitHub currently has no failing checks; the optional Rust CodeQL analysis is still running.

No open decisions or required follow-ups remain. Recommend /quest-merge when the maintainer chooses to land it. This session did not merge or enable auto-merge.

(Written by GPT-6)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging at 719da7f.

  • Goal verified: openmoq/moqx#842 reports the draft-18 TRACK_STATUS refusal with 0xFFFFFFFF; openmoq/moqx#843 tracks emitting only defined codes. The source race fix moq-dev/moq#5991 is merged.
  • Reviews: Codex completed on this head with no findings; CodeRabbit had no actionable comments; no open threads.
  • quest check passes (461 documents). The removed milestone link is the only reference to the quest on main; the branch merges cleanly, so no main merge was needed.

No open decisions or follow-ups.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 005eca0 Oct 22, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/track-status-race branch October 22, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant