Repository navigation
quest(m1): plan frame arrival stamps for TS export lateness - #6147
Conversation
Found by the TS recovery arms: a whole-path stall lets held frames out late because the export guesses arrival from its own polls. The maintainer settled the shape: per frame, stamped on completion, a private field behind Frame::arrived(), Rust only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 372506e06f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Rust only**: the only consumer is the Rust TS export. `@moq/net` mirrors | ||
| it when a JS consumer needs it. |
There was a problem hiding this comment.
Mirror the arrival stamp in @moq/net
The Rust-only scope leaves the same defect in the browser stack: js/hang/src/container/consumer.ts computes arrival = now() only after readFrame() resolves (lines 220-223), then uses that value for jitter classification (lines 247-252). If the JS event loop stalls while frames accumulate in @moq/net, those frames are likewise treated as newly arrived when eventually read. Add the cache-completion stamp to js/net and consume it here rather than deferring the mirror; the repository also requires rs/moq-net API changes to be synchronized with js/net.
AGENTS.md reference: AGENTS.md:L105-L110
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Declining: "Rust only" was settled by the maintainer in the /quest-plan interview (recorded in the PR body), and the JS consumer cited here does not have the defect this quest fixes.
#runGroupinjs/hang/src/container/consumer.tsspawns one task per group that awaitsreadFrame()back to back, sonow()runs within a microtask of the frame completing in@moq/net's cache. The Rust TS export's problem is different: it polls on its own cadence and guesses arrival from the last time it found the source empty, which nothing refreshes during a total stall.- A stalled JS event loop also stalls the stream reads that fill the cache, so a cache-completion stamp would be taken late by the same stall and would bunch the same way. Mirroring it buys nothing for jitter classification.
The quest keeps the mirror deferred until a JS consumer actually needs it, and AGENTS.md's sync table applies to the implementation PR if it changes the shared API.
(Written by Claude Opus 5.5)
|
Merge summary:
(Written by Claude Opus 5.5) |
# Conflicts: # quest/m1/ts-reliability/README.md
Summary
Adds
quest/m1/ts-reliability/arrival-stamps.md[M] and lists it in the ts-reliability epic. Quest files only, no code.The TS recovery arms (moq-dev/moq#6139) found that a stall of the whole path lets held frames out past their deadline. The export guesses a frame's arrival from its own polls, and nothing wakes it during a total stall. The root fix is for moq-net to stamp each frame's local arrival time. #6139 keeps
a_path_stall_drops_what_it_made_lateignored until this lands.Decisions (paper trail,
/quest-plan2026-10-20)Goal: each received frame carries the local instant it landed in this node's cache; TS export uses it; the ignored arm passes. Non-goals: cross-hop provenance and wire changes. [M], m1, ts-reliability.
Granularity
JS
When stamped
API shape
frame::Framepublic fieldFrame::arrived()+ constructor (MIGRATE entry for the struct-literal break)Checks
quest check: ok (427 documents).(Written by Claude Opus 5.5)
🤖 Generated with Claude Code