Repository navigation
fix(mux): bound sequence hole waits by max delay - #5999
Conversation
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Report a genuine missing sequence when the hole budget advances the read cursor, preserving consumer diagnostics while keeping startup joins quiet. Timer and delivery behavior are unchanged. Validation: both shared/post replay regressions now pass after the missing warning failed the full check; 144 container tests and Biome pass. Full rerun and real-browser playback verification remain pending. Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
|
Ad hoc browser playback verification passed at Commands: nix develop --command env MOQ_NO_OPEN=1 just web serve http://localhost:4443
nix develop --command bun .scratch/ts-hole-browser.ts http://localhost:5173/@fs/home/kixelated/work/moq/.worktrees/ts-hole-budget/.scratch/ts-hole-browser.htmlThe scratch probe imported this checkout's container, network, and clock source through Vite. It encoded three VP8 keyframes, delivered them through the real container consumer, decoded them with WebCodecs, and checked the resulting canvas pixels: red With the publisher still open and paused, missing group 1 before bare marker 2 remained waiting at 50 ms, then delivered This verifies in-memory container timing and real browser codec/canvas playback. It does not exercise WebTransport or the player element, run the pinned media/interop harness, or establish an (written by GPT-6.1-Sol) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11a02e2787
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ty/hole-budget Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ty/hole-budget Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4aefbce59a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .hole_timer | ||
| .get_or_insert_with(|| Box::pin(moq_clock::sleep_until(wake))); | ||
| timer.as_mut().reset(wake); | ||
| let _ = waiter.poll_future(timer.as_mut()); |
There was a problem hiding this comment.
Re-evaluate an already-ready hole timer
If the deadline passes between the elapsed check and this poll, poll_future returns Poll::Ready(()), but the result is discarded and the consumer subsequently returns Poll::Pending. Because a future that returns ready does not register or issue another wake, a paused track with no further arrivals can then remain blocked indefinitely instead of expiring the hole; handle the ready result by re-running the expiry decision rather than parking.
AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
…ty/hole-budget Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
A missing group before a bare data marker parks container readers forever while the track stays open and paused. The marker has no timestamp to spend the media-age budget.
Approach
Track when a missing sequence first blocks delivery and wake the reader when the subscription max delay expires. Either the existing media-age rule or elapsed monotonic time can advance the cursor. Keep late groups within budget, reset the anchor for each new hole, and report a gap before the paused marker's end. Preserve skip warnings for genuine expired holes while keeping startup joins quiet. Complete the sequence-hole budget quest.
Impact
Alternatives
A timestamp-only budget cannot advance behind bare markers. A separate timeout setting would duplicate the subscription's existing budget.
Follow-ups
No open design decisions. Full local validation and an ad hoc real-browser exercise are complete; the pinned browser media/interop suites were not run.
Tests
Reproduced missing gap/end failures in Rust and JS before the fix.
Rust container consumer tests: 79 passed via
just rs test, including clippy and mocked-time expiry, wakeup, late arrival, and fresh-hole budgets.JS container tests: 143 passed; final manual-clock hole suite: 3 passed.
bun run --cwd js/hang check, focused Biome, Rust formatting,quest check, andgit diff --checkpassed.The first full
just checkpassed its native checks but failed two watch replay warning assertions. The new expiry path reported gaps without the existing skip diagnostic.At
11a02e278, the diagnostic is restored: both shared/post replay regressions, all 144 container tests, and Biome pass without changing timer or delivery behavior.Full
just checkrerun passed at11a02e27879006581321300de744a48801c4c692(formal exit 0). No CI or review results claimed.Ad hoc real-browser exercise passed at the same head using system Chrome
155.0.8059.79, explicitly selected with PlaywrightexecutablePath, and the existing web dev recipe. Real VP8 encode/container/decode/canvas playback advanced through red, green, and blue, then played the startup frame. A paused, open track missing sequence 1 delivered gap then end for bare marker 2 after 202.755 ms with a 200 ms budget, stayed waiting at 50 ms, and warned exactly once. Startup across an empty/reset group and a missing sequence delivered a frame with no gap or warning. No WebCodecs or page errors.This was an in-memory container-to-WebCodecs browser exercise. It did not exercise WebTransport or the player element, run the pinned media/interop harness, or establish an
--allresult.Iteration (merge with main, Codex review)
origin/main, resolving the conflict with moq-dev/moq#5942:poll_malformedis gone from the read loop,buffer_allis nowlook_all, and main's separate finished-track hole arm stays folded into this PR's single hole arm.(written by GPT-6.1-Sol, iterated by Claude Opus 5.5)
🤖 Generated with Claude Code