Repository navigation
RUBY-3823 Sync change-streams-nsType unified test - #3110
Merged
Merged
Conversation
jamis
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the change-streams unified
nsTypetest fixture, synced from specifications master after DRIVERS-3458.Changes
spec/spec_tests/data/change_streams_unified/change-streams-nsType.yml— new fixture copied fromspecifications/source/change-streams/tests/unified/at0f48bb5. Contains the two remaining tests (nsType is present when creating collections,nsType is present when creating views); the timeseries case removed by DRIVERS-3458 is not present.Why
The Ruby driver never vendored the nsType fixture (RUBY-3615 was closed without adding it), so it was not running the tests in
change-streams-nsType.yml. This brings the driver in line with the spec and with the sibling drivers' DRIVERS-3458 fixes. Test-only change: the Ruby driver returns a rawBSON::Documentfor change stream events, sonsTypeneeds no code change.Test plan
MONGODB_URI="mongodb://localhost:27017,localhost:27018,localhost:27019/" bundle exec rspec spec/spec_tests/change_streams_unified_spec.rb— 88 examples, 0 failures, 21 pending (server 9.1.0 replica set)... -e "nsType is present"— 2 examples, 0 failuresJira: https://jira.mongodb.org/browse/RUBY-3823