Repository navigation
PYTHON-6200 Reset monitor pools to prevent races with close() - #3161
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A deterministic regression test is still needed for the shutdown race in both Monitor and _RttMonitor, since the existing test can pass without exercising the problematic interleaving.
1 open issue
What changed in this PR
This PR addresses PYTHON-6200 by adding monitor-pool cleanup when an executor stops, preventing connections from surviving a shutdown race.
Changes:
- Reset the main monitor’s connections during final cleanup.
- Reset the round-trip-time monitor’s pool when its executor stops.
- Mirror the asynchronous changes in the generated synchronous implementation.
| File | Description |
|---|---|
pymongo/synchronous/monitor.py |
Mirrors the shutdown cleanup in synchronous monitors. |
pymongo/asynchronous/monitor.py |
Adds final pool resets to both asynchronous monitor types. |
Review effort: Balanced
aclark4life
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PYTHON-6200 follow-up
Changes in this PR
Reset monitor pools to prevent a race between the executor being stopped and the monitor being closed.
Test Plan
Existing test suite.
Checklist
Checklist for Author
Checklist for Reviewer