Repository navigation
feat(mongodb-runner): get the SLS tag from the manifest file by default - #911
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The central compose-to-manifest defaulting behavior lacks direct test coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Defaults SLS image tags from the manifest adjacent to the compose file.
Changes:
- Adds manifest parsing and default tag resolution.
- Makes
--slsImageTagoptional. - Adds fixtures, tests, and documentation.
| File | Description |
|---|---|
packages/mongodb-runner/src/sls.ts |
Implements manifest-based tag resolution. |
packages/mongodb-runner/src/sls.spec.ts |
Tests manifest parsing and errors. |
packages/mongodb-runner/src/index.ts |
Exports the manifest reader. |
packages/mongodb-runner/src/cli.ts |
Makes the CLI tag optional. |
packages/mongodb-runner/docs/disaggregated-storage.md |
Documents automatic tag selection. |
packages/mongodb-runner/test/fixtures/sls/complete/manifest.json |
Adds a valid manifest fixture. |
packages/mongodb-runner/test/fixtures/sls/no-key/manifest.json |
Adds a missing-key fixture. |
packages/mongodb-runner/test/fixtures/sls/malformed/manifest.json |
Adds an invalid JSON fixture. |
packages/mongodb-runner/.prettierignore |
Excludes the malformed fixture. |
.prettierignore |
Excludes the malformed fixture globally. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5a13ce0 to
e0b7bf5
Compare
7dc5f22 to
414b9cd
Compare
|
Hi, the check step is failing with |
9dcf8f1 to
22eac2d
Compare
This should be fixed now. |
f8ddfb6 to
22eac2d
Compare
…he build manifest
22eac2d to
412a913
Compare

Description
When running a DSC cluster, the tag to use for the SLS repo is read by default from a
manifest.jsonin the same directory as the required compose file. This is a file in the Server repo that is part of the Server's testing infrastructure for DSC clusters. Other projects can re-use these files for their own test (which we do in mongosync and the DB Tools).If
--slsImageTagis passed, then the runner will not attempt to read the manifest, so this doesn't change the behavior of any existing integrations.Checklist