Skip to content

feat(mongodb-runner): get the SLS tag from the manifest file by default - #911

Merged
autarch merged 1 commit into
mainfrom
08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest
Oct 7, 2026
Merged

autarch merged 1 commit into
mainfrom
08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest

Conversation

@autarch

@autarch autarch commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Description

When running a DSC cluster, the tag to use for the SLS repo is read by default from a manifest.json in the same directory as the required compose file. This is a file in the Server repo that is part of the Server's testing infrastructure for DSC clusters. Other projects can re-use these files for their own test (which we do in mongosync and the DB Tools).

If --slsImageTag is passed, then the runner will not attempt to read the manifest, so this doesn't change the behavior of any existing integrations.

Checklist

Copilot AI balanced review requested due to automatic review settings October 5, 2026 20:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The central compose-to-manifest defaulting behavior lacks direct test coverage.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Defaults SLS image tags from the manifest adjacent to the compose file.

Changes:

  • Adds manifest parsing and default tag resolution.
  • Makes --slsImageTag optional.
  • Adds fixtures, tests, and documentation.
File Description
packages/​mongodb-runner/​src/​sls.ts Implements manifest-based tag resolution.
packages/​mongodb-runner/​src/​sls.spec.ts Tests manifest parsing and errors.
packages/​mongodb-runner/​src/​index.ts Exports the manifest reader.
packages/​mongodb-runner/​src/​cli.ts Makes the CLI tag optional.
packages/​mongodb-runner/​docs/​disaggregated-storage.md Documents automatic tag selection.
packages/​mongodb-runner/​test/​fixtures/​sls/​complete/​manifest.json Adds a valid manifest fixture.
packages/​mongodb-runner/​test/​fixtures/​sls/​no-key/​manifest.json Adds a missing-key fixture.
packages/​mongodb-runner/​test/​fixtures/​sls/​malformed/​manifest.json Adds an invalid JSON fixture.
packages/​mongodb-runner/​.prettierignore Excludes the malformed fixture.
.prettierignore Excludes the malformed fixture globally.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/mongodb-runner/src/sls.ts
@autarch
autarch marked this pull request as ready for review October 5, 2026 20:26
@autarch
autarch requested review from a team as code owners October 5, 2026 20:26
@autarch
autarch requested a review from dudaschar October 5, 2026 20:26
@autarch
autarch force-pushed the 08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest branch from 5a13ce0 to e0b7bf5 Compare October 5, 2026 20:54
@autarch
autarch added this pull request to stack #914 October 5, 2026 20:54
@autarch
autarch force-pushed the 08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest branch 3 times, most recently from 7dc5f22 to 414b9cd Compare October 5, 2026 21:33
@dudaschar

Copy link
Copy Markdown
Collaborator

Hi, the check step is failing with @mongodb-js/mongodb-runner: D:\a\devtools-shared\devtools-shared\packages\mongodb-runner\src\sls.spec.ts @mongodb-js/mongodb-runner: 49:1 error The number of top-level suites is more than 1 mocha/max-top-level-suites Could you take a look on it, please?

@autarch
autarch force-pushed the 08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest branch 2 times, most recently from 9dcf8f1 to 22eac2d Compare October 6, 2026 15:34
@autarch

autarch commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Hi, the check step is failing with @mongodb-js/mongodb-runner: D:\a\devtools-shared\devtools-shared\packages\mongodb-runner\src\sls.spec.ts @mongodb-js/mongodb-runner: 49:1 error The number of top-level suites is more than 1 mocha/max-top-level-suites Could you take a look on it, please?

This should be fixed now.

@autarch autarch changed the title feat(mongodb-runner): get the SLS tag from the manifest file by default feat(mongodb-runner): get the SLS tag from the manifest file by default Oct 7, 2026
@autarch
autarch force-pushed the 08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest branch 2 times, most recently from f8ddfb6 to 22eac2d Compare October 7, 2026 15:42
@autarch
autarch force-pushed the 08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest branch from 22eac2d to 412a913 Compare October 7, 2026 15:56
@autarch
autarch merged commit 035f67a into main Oct 7, 2026
19 checks passed
@autarch
autarch deleted the 08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest branch October 7, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants