Skip to content

feat(custom links): SQL migration - #8017

Closed
logiczsniper wants to merge 1 commit into
modrinth:mainfrom
logiczsniper:lc/user-custom-links/migration
Closed

logiczsniper wants to merge 1 commit into
modrinth:mainfrom
logiczsniper:lc/user-custom-links/migration

Conversation

@logiczsniper

Copy link
Copy Markdown
Contributor

Step 1 as listed in my plan towards #7807.

I opted for a single jsonb column here because:

  1. Small amount of data - max 5ish links per user.
  2. AFAIK the ordering of the links can be preserved via JSON array.
  3. Probably read heavy - so I didn't want to put these in their own table which would require a join for reads.

Added a default value here for backwards compat.

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@logiczsniper

Copy link
Copy Markdown
Contributor Author

Maintainers - in the docs, I didn't see any information on your process for the SQL migrations - I would appreciate any guidance yous could give here 🙇

@Prospector

Copy link
Copy Markdown
Member

this is a feature we're working on ourselves, so we won't be accepting a third party contributions for this

@Prospector Prospector closed this Oct 20, 2026
@logiczsniper

Copy link
Copy Markdown
Contributor Author

@Prospector okay cool, thanks!

Is there some way that I can tell myself what is being worked on / what not? Is there some line drawn dividing work that you will accept open source contributions from?

@Prospector

Copy link
Copy Markdown
Member

Generally, we only accept third party PRs for small bug fixes that also only need a small diff to fix. Anything larger or that requires design work is unlikely to get merged

@logiczsniper

Copy link
Copy Markdown
Contributor Author

@Prospector OK cool, so is there any way to get more involved in that design work? I.e. if I offered you a design for how it would look first. For example for this issue of allowing custom links, the design is pretty straightforward so it felt like I could take a stab at it (but I understand in this case, one of yous is already working on, so this is an exception).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants