Skip to content

fix(deps): raise the rich floor the typer floor requires, and pin the floors before installing them wheel-only - #82

Merged
lesnik512 merged 2 commits into
mainfrom
ci/floors-exact-pins
Sep 27, 2026
Merged

lesnik512 merged 2 commits into
mainfrom
ci/floors-exact-pins

Conversation

@lesnik512

Copy link
Copy Markdown
Member

This PR changes how the floors job installs, following CI6 of the standard (modern-python/.github#115). It first pins every declared floor with builds allowed (uv pip compile ... --resolution lowest-direct --no-deps), then installs those pins with --no-build, plus the dev group at newest.

uv sync --resolution lowest-direct --no-build doesn't fail on a floor that has no wheel for the interpreter. It skips that version and climbs to the lowest one that has a wheel, so the leg passes on a version this repo never declared. Pinning first makes the wheel-only install fail on the real floor instead. compose2pod#139 piloted this.

The comments claiming --no-build fails on a wheel-less floor are removed, since that claim was false. The dev-group comment is removed too: dev dependencies now install at newest, so their floors no longer need to give a usable harness under a lowest resolution.

@lesnik512

Copy link
Copy Markdown
Member Author

Fixed in the second commit. typer>=0.13 requires rich>=10.11.0, so the declared rich>=10.2 could never be installed alongside it. The old lowest-direct job raised rich silently; exact pins surfaced it on every leg. The floor is now rich>=10.11.

@lesnik512 lesnik512 changed the title ci: pin the declared floors before installing them wheel-only fix(deps): raise the rich floor the typer floor requires, and pin the floors before installing them wheel-only Sep 27, 2026
@lesnik512
lesnik512 merged commit b7f337a into main Sep 27, 2026
14 checks passed
@lesnik512
lesnik512 deleted the ci/floors-exact-pins branch September 27, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant