ci: fetch the ADR citation check from .github instead of keeping a copy - #266
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
tests/test_adr_citations.pyand adds thejust adr-checkrecipe andlintstep used by the other 24 repos: fetch the shared check frommodern-python/.githubatmaininto a temp dir inside the repo, run it withpytest --rootdir=. --noconftest -o addopts=.Why
This repo's copy was the stricter variant (bare
ADR-NNNN,.md/.tomlscanning,site/skipped). modern-python/.github#120 made that the shared version, so the copy is now pure duplication, and it was the last one still finding the repo root through__file__. The recipe is byte-identical to eof-fixer's.Verified
just adr-checkagainst.githubmain: 9 passed, rootdir this repo, no temp dir left behind.just lint-ciclean.