Repository navigation
Builder: accept --verify, --keep and --send-test-mail anywhere before -- - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The builder's own options only counted straight after the target. After the first other argument everything went to the create script, so
./build-templates.sh base --vmid 6001 --template --unattended --verify --send-test-mail me@example.comfailed withUnknown argument: --verifyfrom the create script.Now
--verify,--keepand--send-test-mail <addr>are recognised anywhere before a literal--, in any order relative to the create-script args. Every other argument after the target goes to the create script in order. A literal--still ends option parsing: everything after it is passed through as it is, even--verify. The documented forms (base --verify -- --vmid 53000 ...,base -- ..., plainbase) behave as before. Help, header comment and README updated.Behaviour to know about: a create-script value that is one of the three option names (for example
--hostname --keep) must now go after--. The create script has no--verify,--keep,--send-test-mailor--initoptions, so nothing clashes today.--initis also recognised anywhere before--, sobase --vmid 1 --initis now the--initusage error instead of being passed on.Testing
bash -nandshellcheckare clean. Argument parsing was checked on a copy that prints the parsed variables: the failing command above, options before and after--,--verifybefore the target,base -- --verify(passed through), plainbase,--keepwithout--verify,--send-test-mailwith no address,--initand--init base, an unknown target,--generate-only --verify. Real--helpand--initstill work.Not run as root or on a Proxmox host, so no real build was started.