Repository navigation
Builder: refuse the CI_SSH_KEY and WakaTime example values - #57
Merged
Merged
Conversation
verify-clone.sh also reads the config folder, and the builder refuses placeholder ANSIBLE_SSH_PUBKEY and UU_MAIL.
Clone, --init, edit one file, build with --verify.
# Conflicts: # Bash/Proxmox Scripts/Ubuntu Cloud Template/build-templates.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-ups left over from the
--initwork. Stacked on #56 (base branchreadme-quick-start, which is stacked on #55); merge #55, then #56, then this, retargeting to master each time.shared.conf:CI_SSH_KEYstill set togithub.com/<your-github-user>, andWAKATIME_CFGwith theapi_key = xxxxxxxxplaceholder. The README quick start said to set or blank them; now it is enforced, like the Ansible key, mail domain and mail addresses.shared.conf.exampleandprofiles/*.conf.examplesaid "copy to shared.conf ... git-ignored". They now describe./build-templates.sh --initand the config folder, and still mention copying next to the script.Testing
bash -nand shellcheck are clean. With a root-check-stripped copy and fake configs: theCI_SSH_KEYplaceholder is refused, a real value or blank passes; the WakaTime placeholder is refused, a real key, a blank value and a real key that merely starts withxpass.Not run on a real host. Documentation text and one validation each; no change to what gets built.