Repository navigation
Builder: add --verify, --send-test-mail and --keep - #54
Merged
Merged
Conversation
Adds MAIL_RELAY and related settings. GMAIL_USER and GMAIL_APP_PASSWORD still work as the old names.
A login on a port other than 587 or 465 used smtp_tls_security_level=may, so the password could be sent in plain text if TLS failed. It is now encrypt whenever a login is set. Opportunistic TLS stays for a no-login relay.
…e relays verify-clone.sh sources shared.conf on the host and passes only non-secret values to the guest as VERIFY_* variables. verify-template.sh keeps its old defaults when they are not set.
# Conflicts: # Bash/Proxmox Scripts/Ubuntu Cloud Template/README.md
After each build, run verify-clone.sh on the new template and print a summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 3 of the series. Stacked on #53 (base branch
verify-from-shared-conf, which is stacked on #52). Merge #52, then #53, then this; GitHub retargets each time.build-templates.shcan now verify each template right after building it:--verify: after each successful build, runsverify-clone.sh <new-vmid> --profile <target> --config <shared.conf>. Output is live.--send-test-mail <addr>and--keepare passed on. Both are refused without--verify;--verifyis refused with--generate-only.qm listbefore and after the build. Exactly one new ID is the template. Zero or several: a warning, that template is skipped and counted as a failure. The create script's output is not parsed.verify-clone.sh,verify-template.shandqmare present, so a long build is not wasted.VERIFY_CLONEoverrides the path.--keepthe summary lists the kept clones and says to remove them withqm destroy <id> --purge.--config <path>goes on the verify command line; no secrets.README and
--helpupdated.Behaviour change:
--verify,--keepand--send-test-mailplaced after a target are now taken by the builder. The create script has none of these options, so nothing that worked before is lost.Testing
bash -nand shellcheck are clean. Run against stubs and a mockedqm:extras --verify,all --verifywith a failing second verify, a failing second build, zero or two new VMIDs, a failingqm list,--keepwithall, an exit 130 from verify, and every refusal case.--verify, the new script and the previous one give the same create-script calls, output and exit codes.verify-clone.shwas run against the mockqmonce to check it integrates.Not tested: the real
qm listoutput on Proxmox (the first field is taken, with leading spaces tolerated), a real Ctrl-C reaching the builder, and a real build plus verify on a host.