Repository navigation
ImproveSolver - #4864
Open
HansOlsson wants to merge 2 commits into
Open
ImproveSolver#4864HansOlsson wants to merge 2 commits into
HansOlsson wants to merge 2 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Success: Regression testing passed successfully. |
HansOlsson
dismissed
MSL-RegressionTesting-CI’s stale review
November 10, 2026 14:37
The run was interrupted. CI is being improved.
Contributor
Author
|
Note: I didn't add any test-cases as already the existing test-case shows "Improved". @MatthiasBSchaefer would it make sense in these cases to change "Regression testing passed successfully" to something "Regression testing passed successfully, with improvements"? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve non-linear solver in case the starting values are just at the edge (since they might due to round-off be slightly off which causes a failure).
Closes #4719
Note that it is more cautious than the previous fix ( 42f8091 ) to reduce the risk of regressions - but at the cost of making it slightly longer and slightly slower (when it triggers).
We should separately improve the test-cases.