Repository navigation
Keep a contract's harnesses in kani list when the harness is declared first - #5106
Open
Tianshu-Huang wants to merge 1 commit into
Open
Tianshu-Huang wants to merge 1 commit into
Tianshu-Huang wants to merge 1 commit into
Conversation
github-actions
Bot
added
Z-EndToEndBenchCI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kani listshows a contracted function with no harnesses when itsproof_for_contractharness comes before it in the source, for example amod proofs;at the top of the file. The harness creates the function's entry first, and the function then overwrites it with an empty one.Both branches now use
entry(), so nothing is overwritten. When a harness creates the entry it stores the target's name rather than its own; the autoharness lookup below matches on that name and would panic on the old value once entries stop being replaced.New test with one harness before the function and one after; it fails on
mainand passes here. The other list tests andkani autoharness --liston the same crate pass.Resolves #5099.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.