Repository navigation
Enable SGLang CSGMV split-K shrink by default on samplers - #151
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
micahtyong
approved these changes
Oct 28, 2026
Keep the rollout-image split-K flag. Main already enables it for LoRA servers and replaced the DAPO routing fields this branch still carried. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
SGLANG_ENABLE_LORA_CSGMV_SPLIT_K=1in the rollout image so every sampler gets the split-K shrink from sgl-project/sglang#41951. The pinned fork revision already contains the backport (modal-projects/sglang#79); only the flag was off.SGLang applies split-K only to BF16 rank-32 CSGMV shrinks with input size 4096 or 12288 and its default tile shape, and never in deterministic mode. Other models and shapes keep the original kernel. A recipe can still opt out by setting the variable to
0ininference_env.qwen35_9b_instruct_lora_256ksetSGLANG_CSGMV_SPLIT_K, the flag's name before the upstream rename, so split-K never ran there. The DAPO example's explicit setting is now redundant. Both are removed.Validation: deployment tests and pre-commit pass. Not GPU-benchmarked in this PR; the upstream PR has the kernel benchmarks.
Made with Cursor