Repository navigation
fix(cli): handle missing [codecarbon] section and write api_endpoint via ConfigParser - #1433
Open
sohammishra864-wq wants to merge 2 commits into
Open
sohammishra864-wq wants to merge 2 commits into
sohammishra864-wq wants to merge 2 commits into
Conversation
get_api_endpoint now writes the default endpoint via ConfigParser so it lands under [codecarbon] instead of the last section. Fixes mlco2#1432.
davidberenstein1957
approved these changes
Oct 9, 2026
davidberenstein1957
left a comment
Collaborator
There was a problem hiding this comment.
Fixes #1432 cleanly: get_config returning {} and writing api_endpoint through ConfigParser puts the key under [codecarbon] where the reader expects it. One thing worth knowing: config.write rewrites the whole file, so comments in an existing .codecarbon.config are dropped. Acceptable for a config file we own, but a line in the PR description would help.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 49 49
Lines 5199 5200 +1
=======================================
+ Hits 4787 4788 +1
Misses 412 412 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
get_config()now returns{}instead ofNonewhen the config file has no[codecarbon]section.get_api_endpoint()now sets the defaultapi_endpointthroughConfigParserinstead of raw-appending a line, so it always lands under[codecarbon].Related Issue
Fixes #1432
Motivation and Context
show_config()crashed withTypeErroron a config file that had no[codecarbon]section.get_api_endpoint()wrote the key under the last section of multi-section files, so it was never found and got appended again on every call.How Has This Been Tested?
Added two tests in
tests/cli/test_cli_utils.py. Both fail onmasterand pass with this change.pytest tests/cli: 76 passed.Types of changes
AI Usage Disclosure
Checklist: