Repository navigation
Fix Whisper output names containing dots - #1457
Open
akshitkhokhani wants to merge 1 commit into
Open
akshitkhokhani wants to merge 1 commit into
akshitkhokhani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlx_whisper meeting.part1.wavcurrently writesmeeting.txt: the CLI removes the audio extension, then the writer removes.part1as another suffix. A separate invocation formeeting.part2.wavoverwrites that transcript. Explicit--output-name draft.v2similarly becomesdraft.txt, despite the option describing a name before the output-format extension.Append the format extension to the complete output name. Regression tests use real writers/files for TXT, VTT, SRT, TSV, JSON and
all, plus separate single-input CLI invocations with only transcription mocked. They cover dotted audio basenames, an explicit dotted name, and unchanged plain names.Validation:
TestAudio: 3 tests pass on CPU using bundled audio.git diff --checkpasses.The separate multi-input CLI naming issue is tracked by #1441 / #1447. These tests use separate invocations to isolate the writer bug.
AI-assisted source investigation, implementation and tests; a separate AI reviewer checked the change. Human maintainer review is still required.