Repository navigation
fix: handle broken pipes during the final stdout flush - #132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #114.
The existing
BrokenPipeErrorhandler catches drawing failures, but buffered output can still fail when Python flushes stdout during interpreter shutdown. A closed pipe then prints an ignored exception and exits with code 120.Run the complete CLI, including argument parsing and early exits, inside the protected block and flush stdout in a
finallyblock. On a broken pipe, redirect its descriptor toos.devnull, close the extra descriptor, and exit with code 1. This follows the Python documentation's SIGPIPE guidance, and preserves normal output.Validation
--version, and--help. The two additional early-exit cases fail against the initial chart-only fix and pass after moving the full CLI into the protected block. Initial chart regressions: a small buffered chart and a large chart. Both fail against the old production code with code 120 and stderr; both pass with exit 1 and empty stderr after the fix.git diff --checkpasses; Copilot pre-review found no introduced defect.Validated on macOS arm64; Windows execution was not tested. No signal-handler changes or dependencies are introduced.