Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77c6515d09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
77c6515 to
1524c11
Compare
|
Thanks for the review. I independently reproduced and fixed all three P2 findings, added regressions for the nested vendor exclusions, implicit-public nested Java interfaces, and clean-status source reads, and replied to/resolved the three threads. The original patch has been reconciled onto current main: this PR is now three commits / 12 files and has no merge conflicts. The old head is preserved on Final head: The status fix avoids content reads for unchanged include-only candidates, while retaining content checks for Git/dirty-ledger candidates. Included paths still require enumeration/stat checks. |
Changes
codegraph.jsoninclude, including Git-ignored source, while keeping nested vendor dependencies, other dependency/build directories, and explicit excludes out.Branch reconciliation
Replayed the original intended patch onto downstream main after integrating upstream
b635dd467f0578926a9c01a37b9d28d2b26689f1. The PR now contains three commits and 12 changed files, rather than the unrelated 58-commit/60-file history. Enum changes already present on main were retained.The original head is preserved at
backup/pr15-20261008-77c6515.Validation
809a7d95. Both PR CI and push CI completed successfully. Node 22/24 each passed 536 files / 6,632 tests (16 files / 356 tests skipped); native kernel/AOSP passed 31 files / 1,442 tests.npm run build, offlinecargo check, native release build, andgit diff --checkpassed.The status optimization still enumerates/stats included paths. As with
sync(), an ignored file whose bytes change while both size and mtime are preserved needs a forced re-index. This PR makes no claims about the unrelated decompiled vendor corpus.