Skip to content

feat(config): manage ADM-constrained allowed values - #501

Merged
seansica merged 3 commits into
nextfrom
feat/runtime-allowed-values
Sep 30, 2026
Merged

seansica merged 3 commits into
nextfrom
feat/runtime-allowed-values

Conversation

@seansica

Copy link
Copy Markdown
Contributor

Persist editable property/domain rules and derive permissible choices from ADM Zod schemas. Expose catalog, creation, validation, and atomic replacement endpoints.

Quarantine legacy invalid settings and enforce configuration checks independently of validation bypasses. Update OpenAPI, regression coverage, and administration documentation.

Persist editable property/domain rules and derive permissible choices
from ADM Zod schemas. Expose catalog, creation, validation, and atomic
replacement endpoints.

Quarantine legacy invalid settings and enforce configuration checks
independently of validation bypasses. Update OpenAPI, regression coverage,
and administration documentation.
@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.53642% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.99%. Comparing base (0f6ad7e) to head (eb492e2).
⚠️ Report is 4 commits behind head on next.

Files with missing lines Patch % Lines
app/repository/allowed-values-repository.js 88.97% 13 Missing and 1 partial ⚠️
app/services/system/allowed-values-service.js 96.02% 7 Missing ⚠️
app/controllers/allowed-values-controller.js 92.00% 6 Missing ⚠️
app/lib/allowed-values-catalog.js 96.27% 5 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #501      +/-   ##
==========================================
+ Coverage   81.62%   81.99%   +0.36%     
==========================================
  Files         246      252       +6     
  Lines       40606    41202     +596     
  Branches     5138     5311     +173     
==========================================
+ Hits        33146    33782     +636     
+ Misses       7368     7326      -42     
- Partials       92       94       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Document ADM version provenance, initialization, value additions,
package upgrades, and read-time quarantine. Clarify the bundled JSON
file's continuing role and repair documentation links.

Remove tracked TODO and frontend handoff logs while preserving ignored
root copies. Update agent guidance and exclude local logs from Git
and Docker builds.
@seansica
seansica marked this pull request as ready for review September 30, 2026 02:25
@seansica
seansica merged commit 69b37fe into next Sep 30, 2026
1 check passed
@seansica
seansica deleted the feat/runtime-allowed-values branch September 30, 2026 02:28
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@seansica
seansica restored the feat/runtime-allowed-values branch September 30, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants