Skip to content

feat(docker): add frontend live reload - #857

Merged
seansica merged 4 commits into
nextfrom
feat/live-reload-dev-workflow
Oct 16, 2026
Merged

seansica merged 4 commits into
nextfrom
feat/live-reload-dev-workflow

Conversation

@scotluns

@scotluns scotluns commented May 20, 2026 •

Copy link
Copy Markdown

Summary

Configure the same frontend image for different Workbench instances without rebuilding Angular. Native commands and containers share a validated public configuration contract; the browser loads settings before bootstrap.

build defaults + optional JSON + environment overrides
  → validate and generate /assets/config.json
  → load one immutable configuration
  → bootstrap Angular and API consumers

Adds a dev Docker target with Angular polling and same-origin API proxying. Production startup generates settings before Nginx starts; configuration responses use Cache-Control: no-store. Build metadata stays separate. Documents native, container, and static-host configuration, and makes live REST API integration tests opt-in.

Evidence

  • Before: Angular environment files supplied build-time settings, and application configuration was loaded separately.
    After: Runtime bootstrap tests cover mode defaults, shared immutable settings, meaningful empty/false overrides, and rejection of missing or invalid configuration before consumers start.
  • After: CI passed commitlint, the static-check job, and tests with coverage. The static-check job uses warning-only linting. Live-server integration tests require WORKBENCH_FRONTEND_TEST_API_URL; this CI result does not establish Compose compatibility or a published-image build.

Merge Danger

Door: two-way

Revert the code and accompanying configuration changes. Merge before deployment PR #6.

Blast Radius: frontend

Affects startup, browser API routing, application settings, and production image entrypoint behavior. Invalid public settings prevent startup. Container environment changes require recreation; mounted JSON changes require restart and browser reload. Keep credentials in the REST API.

Related PRs

@jondricek
jondricek force-pushed the feat/live-reload-dev-workflow branch from d67ed7e to b5a0c00 Compare October 12, 2026 13:00
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 72.63682% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.30%. Comparing base (79b0f6d) to head (b5a0c00).

Files with missing lines Patch % Lines
src/configuration/public-configuration.ts 72.53% 39 Missing ⚠️
...x/relationship-view/relationship-view.component.ts 0.00% 5 Missing ⚠️
...p/components/stix/stix-list/stix-list.component.ts 0.00% 3 Missing ⚠️
src/app/services/config/app-config.service.ts 50.00% 2 Missing ⚠️
...website-integration/website-integration.service.ts 33.33% 2 Missing ⚠️
...onnectors/authentication/authentication.service.ts 50.00% 1 Missing ⚠️
.../connectors/rest-api/rest-api-connector.service.ts 50.00% 1 Missing ⚠️
...-index-import/collection-index-import.component.ts 50.00% 1 Missing ⚠️
...ction/collection-view/collection-view.component.ts 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #857      +/-   ##
==========================================
- Coverage   49.47%   49.30%   -0.18%     
==========================================
  Files         214      216       +2     
  Lines       29203    29362     +159     
  Branches     2365     2379      +14     
==========================================
+ Hits        14448    14476      +28     
- Misses      14666    14797     +131     
  Partials       89       89              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seansica
seansica merged commit 647870c into next Oct 16, 2026
4 checks passed
@seansica
seansica deleted the feat/live-reload-dev-workflow branch October 16, 2026 20:24
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants