Repository navigation
Update the ignored phpstan errors - #70
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=========================================
Coverage 89.06% 89.06%
Complexity 197 197
=========================================
Files 1 1
Lines 494 494
=========================================
Hits 440 440
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stof
commented
Oct 6, 2026
| path: src/WebdriverClassicDriver.php | ||
| - | ||
| # TODO provide a more precise type for the keypress, keydown and keyup methods in the DriverInterface of Mink | ||
| rawMessage: 'Parameter #1 $codepoint of function chr expects int<0, 255>, int given.' |
Member
Author
There was a problem hiding this comment.
it looks like this error is not reported on PHP 8.2. This should be retried once #65 is merged.
Member
|
@stof generally looks fine to me, please merge in latest main - I think it should then solve the remaining issues. |
uuf6429
approved these changes
Oct 11, 2026
uuf6429
left a comment
uuf6429
left a comment
Member
There was a problem hiding this comment.
I'm approving and merging as is since it's clear this solves some issues and worst case couldn't affect users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.