Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Android dependency remains on SDK 2.15.4, which lacks the newly called builder method and causes compilation to fail.
1 open finding
What changed in this PR
Adds Android support for disabling tracking identifier collection during SDK initialization.
Changes:
- Adds
disableTrackingIdsto the public initialization API. - Passes the option through JavaScript to Android.
- Adds JavaScript payload tests.
| File | Description |
|---|---|
src/types/InitializationData.ts |
Defines and documents the option. |
src/index.tsx |
Adds the option to native initialization payloads. |
src/__tests__/index.test.ts |
Tests true, false, and omitted values. |
android/src/main/java/com/mindboxsdk/MindboxSdkModule.kt |
Applies the option to the Android configuration builder. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| configurationBuilder.shouldIncludeVersionCode(payload.optBoolean("shouldIncludeVersionCode", true)) | ||
| } | ||
| if (payload.has("disableTrackingIds")) { | ||
| configurationBuilder.disableTrackingIds(payload.optBoolean("disableTrackingIds", false)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-389
Android only:
InitializationData.disableTrackingIdsis passed toMindboxConfiguration.Builder.disableTrackingIdswhen set; iOS ignores the key.Merge after the Android SDK release that contains
disableTrackingIds(2.15.4 and 2.16.0-rc don't have it), together with the dependency bump: until then the Android build fails.