Skip to content

ci: Add required CI check - #48

Merged
ecv merged 1 commit into
mainfrom
ci/required-ci-check
Nov 2, 2026
Merged

ecv merged 1 commit into
mainfrom
ci/required-ci-check

Conversation

@ecv

@ecv ecv commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Pull requests can merge with a red or missing build, because no check is required to pass. This adds a ci job that calls the shared ci-basic workflow, so every pull request reports ci / Build and test, ready for infra to require.

What it runs: scripts/verify_manifests.py validates every manifest against the schema and downloads each public release asset to verify its checksum. This is the same script validate.yaml ran, with pinned jsonschema and PyYAML in a venv. It contacts public GitHub releases only, no secrets.

Dropped: validate.yaml, covered by the new check (it also used a custom runner variable).

Required checks: none (the main ruleset is disabled and requires none).

Fixes #47

Pull requests could merge with a red or missing build because no check was
required. Call the shared ci-basic workflow from a job named ci so the
check reports as ci / Build and test.

It runs scripts/verify_manifests.py, which validates every manifest
against the schema and verifies each published release asset checksum.
The old validate.yaml is removed, as it ran the same script.
@ecv
ecv requested a review from andrewb3000 November 2, 2026 21:39
@ecv
ecv merged commit 544f273 into main Nov 2, 2026
1 check passed
@ecv
ecv deleted the ci/required-ci-check branch November 2, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require a passing CI check to merge

2 participants