Repository navigation
fix: bump Microting.eFormApi.BasePn to 10.0.40 - #1768
Merged
Merged
Conversation
Picks up the BasePn fix where the plugin configuration provider now merges seed defaults for keys missing from PluginConfigurationValues and PluginDbOptions.GetList skips null properties instead of throwing a NullReferenceException. Saving TimePlanning settings no longer fails when a newly seeded setting is absent from the in-memory configuration. Refs microting/eFormApi.BasePn#978 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the base-library dependency update.
No open issues 🎉
What changed in this PR
Updates TimePlanning’s base-library dependency to incorporate the upstream fix for settings saves failing when newly seeded settings are missing from in-memory configuration.
Changes:
- Bumps
Microting.eFormApi.BasePnfrom10.0.39to10.0.40. - No application code or local tests are changed; regression coverage is provided upstream.
| File | Description |
|---|---|
eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/TimePlanning.Pn.csproj |
Updates the base-library package reference to 10.0.40. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Saving TimePlanning settings could fail with a
NullReferenceExceptionfromPluginDbOptions<T>.GetListwhen a recently seeded setting (e.g.PauseIdSelfHealEnabled) was not present in the in-memory plugin configuration. The configuration provider is loaded before the plugin seeds missing rows, and the provider only fell back to seed data when the table was entirely empty.Fix
The fix lives in the base library (microting/eFormApi.BasePn#979, released as 10.0.40):
PluginConfigurationProvider.Loadstarts from the seed defaults and overlays the database rows.PluginDbOptions.GetListskips null properties instead of throwing.This PR only bumps the
Microting.eFormApi.BasePnpackage reference inTimePlanning.Pn.csprojfrom 10.0.39 to 10.0.40.Tests
The regression tests (
PluginConfigurationTests) were added and pass in eFormApi.BasePn's CI. Locally,dotnet buildofTimePlanning.Pnsucceeds with the new package. CI here should stay green with the existing suites.Refs microting/eFormApi.BasePn#978
Kanban card #5367
🤖 Generated with Claude Code